You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/03 13:37:38 UTC
[GitHub] [airflow] jstern opened a new pull request #8095: stop rendering
some class docs in wrong place
jstern opened a new pull request #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095
Docs generated for providers.yandex.hooks incorrectly include docs for airflow.exceptions.AirflowException and airflow.hooks.base_hook.BaseHook in the yandex module, as if those classes had been defined in that module.
This is almost certainly a bug in autoapi or one of the libraries it uses, but I haven't tracked down the root cause. In the meantime, importing the modules and then referring to the classes using modulename.Classname avoids the issue.
Before this change, yandex docs include AirflowException and BaseHook under the wrong fully qualified names:
<img width="763" alt="Screen Shot 2020-03-28 at 4 36 56 PM" src="https://user-images.githubusercontent.com/617540/77834402-87357900-7112-11ea-8561-43fe7941ada1.png">
After, yandex docs include only objects defined in that module:
<img width="797" alt="Screen Shot 2020-04-03 at 8 28 46 AM" src="https://user-images.githubusercontent.com/617540/78365799-3d6ee780-7585-11ea-8033-0047a9105e43.png">
In addition to being wrong in and of itself, these docs being out of place are causing doc warnings in another PR where I have added `airflow.exceptions` to the api docs (https://github.com/apache/airflow/pull/7133).
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #8095: stop rendering some class
docs in wrong place
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-609038012
I'm surprised that it treats `__init__` differently, but it could I guess
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8095: stop rendering some class
docs in wrong place
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-614703960
> Ok @kaxil @turbaszek I'm up for making this change. It does have some ripple effects: one is that it requires minor changes to operators-and-hooks-ref.rst, which is no problem. Another is that test_project_structure fails because the new module does not have a corresponding test module. Question for the group: presumably YandexCloudBaseHook is covered by tests of airflow.providers.yandex.hooks.yandexcloud_dataproc.DataprocHook. Should I write a test suite anyway for YandexCloudBaseHook? Or should I add the new module to MISSING_TEST_FILES in tests/test_project_structure.py?
Let's keep it in MISSING_TEST_FILES for now and we can revisit it later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608514179
@mik-laj you are experienced with our docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jstern commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
jstern commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-609050848
> I'm surprised that it treats `__init__` differently, but it could I guess
Well, I don't know. I'm just kind of speculating randomly :)
Any reason this can't be merged at this point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jstern commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
jstern commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608564074
will try the `__all__` approach locally and update the pr to use that if it works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #8095: stop rendering some class
docs in wrong place
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608498972
I wonder if this is a more general problem elsewhere too...?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8095: stop
rendering some class docs in wrong place
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608724015
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=h1) Report
> Merging [#8095](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/10542e0ab85397edbb38949097876ba5c1839bd0&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8095 +/- ##
==========================================
+ Coverage 87.27% 87.49% +0.21%
==========================================
Files 937 934 -3
Lines 45556 45192 -364
==========================================
- Hits 39760 39540 -220
+ Misses 5796 5652 -144
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/yandex/hooks/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMveWFuZGV4L2hvb2tzL19faW5pdF9fLnB5) | `85.29% <100.00%> (+0.44%)` | :arrow_up: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0.00%> (-54.93%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=footer). Last update [10542e0...ca6a901](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jstern commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
jstern commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-610959208
Ok @kaxil @turbaszek I'm up for making this change. It does have some ripple effects: one is that it requires minor changes to operators-and-hooks-ref.rst, which is no problem. Another is that test_project_structure fails because the new module does not have a corresponding test module. Question for the group: presumably YandexCloudBaseHook is covered by tests of airflow.providers.yandex.hooks.yandexcloud_dataproc.DataprocHook. Should I write a test suite anyway for YandexCloudBaseHook? Or should I add the new module to MISSING_TEST_FILES in tests/test_project_structure.py?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608531275
@turbaszek I have no solution to this problem and I am also aware of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #8095: stop rendering
some class docs in wrong place
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-614703960
> Ok @kaxil @turbaszek I'm up for making this change. It does have some ripple effects: one is that it requires minor changes to operators-and-hooks-ref.rst, which is no problem. Another is that test_project_structure fails because the new module does not have a corresponding test module. Question for the group: presumably YandexCloudBaseHook is covered by tests of airflow.providers.yandex.hooks.yandexcloud_dataproc.DataprocHook. Should I write a test suite anyway for YandexCloudBaseHook? Or should I add the new module to MISSING_TEST_FILES in tests/test_project_structure.py?
Let's keep it in MISSING_TEST_FILES for now and we can revisit it later in a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jstern commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
jstern commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608527190
> I wonder if this is a more general problem elsewhere too...?
Me too.
A cursory check just for these two cases doesn't turn anything up in the built docs in my branch:
```
11:05:07 jstern@US-C02V518BHTD7:html/ (fix-yandex-doc-imports)
$ ag "Base class for all hooks"
_modules/airflow/hooks/base_hook.html
216:<span class="sd">"""Base class for all hooks"""</span>
_sources/_api/airflow/hooks/base_hook/index.rst.txt
8: Base class for all hooks
_api/airflow/hooks/base_hook/index.html
276:<p><p>Base class for all hooks</p>
11:05:27 jstern@US-C02V518BHTD7:html/ (fix-yandex-doc-imports)
$ ag "Base class for all Airflow's errors"
11:05:46 jstern@US-C02V518BHTD7:html/ (fix-yandex-doc-imports)
```
But perhaps there are other cases.
My hunch is that this has something to do with the fact that the doc in question is for an `__index__.py` file...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jstern commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
jstern commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-610430620
> Why not move the contents of `airflow/providers/yandex/hooks/__init__.py`
As someone who is in no way involved with yandex or using/maintaining the yandex provider code I felt like I should make my edits as minor as possible; reorganizing the code didn't feel like a decision it was mine to make. If the airflow committers and/or contributors of the yandex code want me to do that instead, I'm happy to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-610781063
@jstern I think Yandex is only available on master so we can move the code without any consequences
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] jstern commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
jstern commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-609027198
```python
__all__ = ['YandexCloudBaseHook']
```
This works (needs to be a string though since it's a list of names). Thanks for the suggestion @ashb I agree it makes more sense than my first pass.
Starting to wonder if there really isn't a bug with autoapi and it's more just a thing to keep in mind about how people use `__init__` modules; I think it's pretty normal to import names into those modules to expose them more conveniently, and if you're asking people to prefer importing `a.X` over `a.b.c.X` you probably would want your docs to reflect `a.X` ... only in this case the names we're importing come from a totally different place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #8095: stop
rendering some class docs in wrong place
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608724015
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=h1) Report
> Merging [#8095](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/10542e0ab85397edbb38949097876ba5c1839bd0&el=desc) will **increase** coverage by `0.35%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8095 +/- ##
==========================================
+ Coverage 87.27% 87.63% +0.35%
==========================================
Files 937 934 -3
Lines 45556 45192 -364
==========================================
- Hits 39760 39605 -155
+ Misses 5796 5587 -209
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/yandex/hooks/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMveWFuZGV4L2hvb2tzL19faW5pdF9fLnB5) | `85.29% <100.00%> (+0.44%)` | :arrow_up: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=footer). Last update [10542e0...ca6a901](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8095: stop rendering some class
docs in wrong place
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-610396684
Why not move the contents of `airflow/providers/yandex/hooks/__init__.py` to `airflow/providers/yandex/hooks/yandex.py` and have an empty `__init.py` similar to https://github.com/apache/airflow/blob/master/airflow/providers/salesforce/hooks/salesforce.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #8095: stop rendering some
class docs in wrong place
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608724015
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=h1) Report
> Merging [#8095](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/10542e0ab85397edbb38949097876ba5c1839bd0&el=desc) will **decrease** coverage by `21.59%`.
> The diff coverage is `74.33%`.
[](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8095 +/- ##
===========================================
- Coverage 87.27% 65.68% -21.60%
===========================================
Files 937 934 -3
Lines 45556 45192 -364
===========================================
- Hits 39760 29683 -10077
- Misses 5796 15509 +9713
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/debug\_executor.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGVidWdfZXhlY3V0b3IucHk=) | `28.57% <ø> (-63.50%)` | :arrow_down: |
| [airflow/executors/local\_executor.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvbG9jYWxfZXhlY3V0b3IucHk=) | `28.57% <ø> (-63.91%)` | :arrow_down: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `75.35% <ø> (-19.72%)` | :arrow_down: |
| [...low/providers/microsoft/azure/hooks/azure\_batch.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL2hvb2tzL2F6dXJlX2JhdGNoLnB5) | `67.67% <67.67%> (ø)` | |
| [...providers/microsoft/azure/operators/azure\_batch.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9henVyZV9iYXRjaC5weQ==) | `80.48% <80.48%> (ø)` | |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `85.13% <100.00%> (-3.38%)` | :arrow_down: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `25.75% <100.00%> (-56.07%)` | :arrow_down: |
| [airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==) | `17.08% <100.00%> (-39.80%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `48.00% <100.00%> (-52.00%)` | :arrow_down: |
| [airflow/providers/yandex/hooks/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMveWFuZGV4L2hvb2tzL19faW5pdF9fLnB5) | `85.29% <100.00%> (+0.44%)` | :arrow_up: |
| ... and [516 more](https://codecov.io/gh/apache/airflow/pull/8095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=footer). Last update [10542e0...ca6a901](https://codecov.io/gh/apache/airflow/pull/8095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #8095: stop rendering some class
docs in wrong place
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #8095: stop rendering some class docs in wrong place
URL: https://github.com/apache/airflow/pull/8095#issuecomment-608530805
```python
__all__ = [YandexCloudBaseHook]
```
may work as well and is a less-obscure fix. (That controls what is "imported" when using a python module)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services