You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (Resolved) (JIRA)" <ji...@apache.org> on 2011/11/03 10:51:32 UTC

[jira] [Resolved] (BOOKKEEPER-60) confusion between multiple "consume" methods

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira resolved BOOKKEEPER-60.
----------------------------------------

    Resolution: Duplicate

Solved in BOOKKEEPER-90.
                
> confusion between multiple "consume" methods
> --------------------------------------------
>
>                 Key: BOOKKEEPER-60
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-60
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: hedwig-client
>            Reporter: Matthieu Morel
>            Priority: Minor
>             Fix For: 4.0.0
>
>
> There are currently 2 methods named "consume" in the client API:
> - in org.apache.hedwig.client.api.MessageHandler : delegates the processing of a message by a message handler
> - in org.apache.hedwig.client.api.Subscriber : notifies the server that messages have been processed till a given sequence id. This is some kind of acknowledgement.
> I don't think these 2 fundamental methods should be named the same: they have different purposes and it is confusing.
> Couldn't we rename Subscriber.consume into Subscriber.acknowledge, or something similar?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira