You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/03 21:46:19 UTC

[GitHub] [arrow-datafusion] vchag opened a new pull request #1919: fix a typo

vchag opened a new pull request #1919:
URL: https://github.com/apache/arrow-datafusion/pull/1919


   Change-Id: I64d2169a616efb889b3e37e85450405729eed499
   
   # Which issue does this PR close?
   This PR is related to correcting a typo and not related to functionality issues.  
   
   Closes #.
    # Rationale for this change
   I made this change to ensure users don't get confused. Comments help new users like me understand the code. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] vchag commented on pull request #1919: fix a typo

Posted by GitBox <gi...@apache.org>.
vchag commented on pull request #1919:
URL: https://github.com/apache/arrow-datafusion/pull/1919#issuecomment-1061236571


   > xudong963
   
   Thanks for pointing it out. I'll fix it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] vchag commented on pull request #1919: fix a typo

Posted by GitBox <gi...@apache.org>.
vchag commented on pull request #1919:
URL: https://github.com/apache/arrow-datafusion/pull/1919#issuecomment-1061242381


   > Thanks @vchag -- please let me know if you want to fix @xudong963 's suggestion in this PR or if I should merge this one as is
   
   your welcome @alamb.  I fixed the typo in the other file. You can merge both of these changes.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp merged pull request #1919: fix a typo

Posted by GitBox <gi...@apache.org>.
houqp merged pull request #1919:
URL: https://github.com/apache/arrow-datafusion/pull/1919


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1919: fix a typo

Posted by GitBox <gi...@apache.org>.
xudong963 commented on pull request #1919:
URL: https://github.com/apache/arrow-datafusion/pull/1919#issuecomment-1058720229


   I noticed https://github.com/apache/arrow-datafusion/blob/bc42eadd5b03cc4e1c541f4e37ab5f54fa3db714/datafusion-common/src/dfschema.rs#L287 has the same typo, could you please fix it together?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] vchag edited a comment on pull request #1919: fix a typo

Posted by GitBox <gi...@apache.org>.
vchag edited a comment on pull request #1919:
URL: https://github.com/apache/arrow-datafusion/pull/1919#issuecomment-1061242381


   > Thanks @vchag -- please let me know if you want to fix @xudong963 's suggestion in this PR or if I should merge this one as is
   
   you're welcome @alamb.  I fixed the typo in the other file. You can merge both of these changes.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org