You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "caiconghui (via GitHub)" <gi...@apache.org> on 2023/06/13 11:44:40 UTC
[GitHub] [doris] caiconghui opened a new pull request, #20759: [enhancement](log4j) support high performance mode for log4j to escape potential bottleneck for doris read and write
caiconghui opened a new pull request, #20759:
URL: https://github.com/apache/doris/pull/20759
## Proposed changes
Issue Number: close #xxx
As we know, log4j2 some times may be bottleneck in doris fe when there are many logs to be output in sync mode while asynchronous logging has a better performance， and we find that capturing caller location has a similar impact across all logging libraries, and slows down asynchronous logging by about 30-100x. so, here we provide three log mode for log4j2 to meet the needs of different users.
refer to https://logging.apache.org/log4j/2.x/performance.html
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20759: [enhancement](log4j) support high performance mode for log4j2 to escape potential bottleneck for doris read and write
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #20759:
URL: https://github.com/apache/doris/pull/20759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #20759: [enhancement](log4j) support high performance mode for log4j2 to escape potential bottleneck for doris read and write
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #20759:
URL: https://github.com/apache/doris/pull/20759#discussion_r1229078138
##########
conf/fe.conf:
##########
@@ -38,6 +38,9 @@ JAVA_OPTS_FOR_JDK_9="-Xss4m -Xmx8192m -XX:SurvivorRatio=8 -XX:MaxTenuringThresho
# INFO, WARN, ERROR, FATAL
sys_log_level = INFO
+# NORMAL, BRIEF, ASYNC
+sys_log_mode = NORMAL
Review Comment:
comment this line and set normal as default value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] caiconghui commented on pull request #20759: [enhancement](log4j) support high performance mode for log4j to escape potential bottleneck for doris read and write
Posted by "caiconghui (via GitHub)" <gi...@apache.org>.
caiconghui commented on PR #20759:
URL: https://github.com/apache/doris/pull/20759#issuecomment-1589143620
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20759: [enhancement](log4j) support high performance mode for log4j2 to escape potential bottleneck for doris read and write
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20759:
URL: https://github.com/apache/doris/pull/20759#issuecomment-1590428847
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20759: [enhancement](log4j) support high performance mode for log4j2 to escape potential bottleneck for doris read and write
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20759:
URL: https://github.com/apache/doris/pull/20759#issuecomment-1590428868
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org