[GitHub] [rocketmq-externals] ShadowySpirits commented on a change in pull request #466: [ISSUE #465] Add friendly reminder for the lack of cluster store topic

[GitBox <gi...@apache.org>]

ShadowySpirits commented on a change in pull request #466: [ISSUE #465] Add friendly reminder for the lack of cluster store topic
URL: https://github.com/apache/rocketmq-externals/pull/466#discussion_r347696916
 
 

 ##########
 File path: rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/ClusterManagementServiceImpl.java
 ##########
 @@ -81,6 +81,14 @@ public void stop() {
         this.defaultMQPullConsumer.shutdown();
     }
 
+    @Override
+    public boolean hasClusterStoreTopic() {
 
 Review comment:
   Wether automatically create a topic or not depends on the config of broker. I didn't find a mechanism to manually create a topic from the client. Therefore add autoCreateTopicEnable to connector maybe lead to misunderstanding.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services