[GitHub] [airflow] josh-fell commented on a diff in pull request #29166: Correct tenant eval within async logic of DbtCloudHook

["josh-fell (via GitHub)" <gi...@apache.org>]

josh-fell commented on code in PR #29166:
URL: https://github.com/apache/airflow/pull/29166#discussion_r1093946334


##########
airflow/providers/dbt/cloud/hooks/dbt.py:
##########
@@ -181,33 +181,46 @@ def __init__(self, dbt_cloud_conn_id: str = default_conn_name, *args, **kwargs)
         super().__init__(auth_type=TokenAuth)
         self.dbt_cloud_conn_id = dbt_cloud_conn_id
 
+    @staticmethod
+    def _get_tenant_domain(conn: Connection) -> str:
+        if conn.schema:
+            warnings.warn(

Review Comment:
   Done. Do you think this warrants a newsfragment or does the major version increment imply something "newsworthy"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org