You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (Created) (JIRA)" <ji...@apache.org> on 2012/03/27 16:02:34 UTC
[jira] [Created] (HBASE-5645) [findbugs] Fix correctness warnings
[findbugs] Fix correctness warnings
-----------------------------------
Key: HBASE-5645
URL: https://issues.apache.org/jira/browse/HBASE-5645
Project: HBase
Issue Type: Sub-task
Reporter: Jonathan Hsieh
See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Status: In Progress (was: Patch Available)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252225#comment-13252225 ]
Hudson commented on HBASE-5645:
-------------------------------
Integrated in HBase-TRUNK-security #168 (See [https://builds.apache.org/job/HBase-TRUNK-security/168/])
HBASE-5645 [findbugs] Fix correctness warnings (David S Wang and Uma Maheswara Rao G) (Revision 1324969)
Result = FAILURE
jmhsieh :
Files :
* /hbase/trunk/dev-support/findHangingTest.sh
* /hbase/trunk/dev-support/test-patch.properties
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Fix For: 0.96.0
>
> Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251809#comment-13251809 ]
Uma Maheswara Rao G commented on HBASE-5645:
--------------------------------------------
Attached the same patch as David and exclude Hlog file as that was already handled. also not included ShutDownHook and Store changes as they already handled. Also updated the count in test-patch.properties.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251353#comment-13251353 ]
Uma Maheswara Rao G commented on HBASE-5645:
--------------------------------------------
Jon, I think #1 and #2 also need to update in this patch right (ShutdownHook.java
and Store.java changes). null checks might be redundant now.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5645:
----------------------------------
Comment: was deleted
(was: lgtm.
I just checked in HBASE_5653 that reduced the find bugs number, which likely "breaks" this patch. I'm going to submit patch to find out the new number and the tweak v2 to reflect this new number.)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251306#comment-13251306 ]
David S. Wang commented on HBASE-5645:
--------------------------------------
Not high priority obviously, but if someone gets a chance to look at the new patch and commit it, I would appreciate it before the patch gets out of sync with trunk again.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246485#comment-13246485 ]
Hadoop QA commented on HBASE-5645:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521333/HBASE-5645.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1385//console
This message is automatically generated.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5645:
---------------------------------------
Attachment: HBASE-5645-3.patch
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251331#comment-13251331 ]
Jonathan Hsieh commented on HBASE-5645:
---------------------------------------
lgtm.
I just checked in HBASE_5653 that reduced the find bugs number, which likely "breaks" this patch. I'm going to submit patch to find out the new number and the tweak v2 to reflect this new number.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250969#comment-13250969 ]
jiraposter@reviews.apache.org commented on HBASE-5645:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4612/
-----------------------------------------------------------
(Updated 2012-04-10 19:11:48.808176)
Review request for hbase.
Changes
-------
Updated patch to work with trunk. Fixed hanging test. Ran test-patch.sh and -PrunAllTests.
Summary
-------
Fixes for issues reported in findbugs for "Correctness" category.
This addresses bug HBASE-5645.
https://issues.apache.org/jira/browse/HBASE-5645
Diffs (updated)
-----
dev-support/findHangingTest.sh 4518c68
dev-support/test-patch.properties 203df69
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java c4a8a9e
src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 63b2ed5
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java de4b1e6
src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832
src/main/java/org/apache/hadoop/hbase/master/HMaster.java fb21bdd
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1c253a0
src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897
src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 00f8d99
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java bf1618e
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 1636bfb
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 545bd02
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0
src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c
src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856
Diff: https://reviews.apache.org/r/4612/diff
Testing
-------
Ran test-patch.sh and unit tests.
Thanks,
David
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5645:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Lgtm. Thanks David and thanks Uma and Stack for taking a look. I've committed to trunk.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Fix For: 0.96.0
>
> Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245881#comment-13245881 ]
Hadoop QA commented on HBASE-5645:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521234/HBASE-5645.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1381//console
This message is automatically generated.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245862#comment-13245862 ]
jiraposter@reviews.apache.org commented on HBASE-5645:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4612/
-----------------------------------------------------------
(Updated 2012-04-03 22:54:54.016499)
Review request for hbase.
Changes
-------
Corrected JIRA number.
Summary (updated)
-------
Fixes for issues reported in findbugs for "Correctness" category.
This addresses bug HBASE-5645.
https://issues.apache.org/jira/browse/HBASE-5645
Diffs
-----
dev-support/test-patch.properties 2209d27
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba
src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15
src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3
src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897
src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 8950c9f
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0
src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c
src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4
src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856
Diff: https://reviews.apache.org/r/4612/diff
Testing
-------
Ran test-patch.sh and unit tests.
Thanks,
David
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251855#comment-13251855 ]
Hadoop QA commented on HBASE-5645:
----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522291/HBASE-5645-3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1482//console
This message is automatically generated.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Attachment: HBASE-5645-2.patch
Updated to latest trunk; fixed test hang. Passed -PrunAllTests and test-patch.sh. Will attach to reviewboard once this passes the robot.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5645:
----------------------------------
Attachment: hbase-5645-2-tweak.patch
Attached a tweaked version that excludes an HLog change already included by HBASE-5653 and removed count update so we can get new count.
Letting bot run to get new findbugs count.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250797#comment-13250797 ]
Hadoop QA commented on HBASE-5645:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522118/HBASE-5645-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1462//console
This message is automatically generated.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang reassigned HBASE-5645:
------------------------------------
Assignee: David S. Wang
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5645:
-------------------------
Status: Open (was: Patch Available)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247804#comment-13247804 ]
Hadoop QA commented on HBASE-5645:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521593/HBASE-5645.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1416//console
This message is automatically generated.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245898#comment-13245898 ]
jiraposter@reviews.apache.org commented on HBASE-5645:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4612/#review6666
-----------------------------------------------------------
Ship it!
Looks good to me.
dev-support/test-patch.properties
<https://reviews.apache.org/r/4612/#comment14421>
Hurray!
- Michael
On 2012-04-03 22:54:54, David Wang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4612/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-03 22:54:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixes for issues reported in findbugs for "Correctness" category.
bq.
bq.
bq. This addresses bug HBASE-5645.
bq. https://issues.apache.org/jira/browse/HBASE-5645
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. dev-support/test-patch.properties 2209d27
bq. src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15
bq. src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3
bq. src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897
bq. src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e
bq. src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d
bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 8950c9f
bq. src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac
bq. src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0
bq. src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c
bq. src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4
bq. src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856
bq.
bq. Diff: https://reviews.apache.org/r/4612/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran test-patch.sh and unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. David
bq.
bq.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247730#comment-13247730 ]
David S. Wang commented on HBASE-5645:
--------------------------------------
Thanks for the pointer. Unfortunately, this doesn't seem to help:
[dsw@c1502 hbase]$ dev-support/findHangingTest.sh https://builds.apache.org/job/PreCommit-HBASE-Build/1385//console
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 142k 0 142k 0 0 315k 0 --:--:-- --:--:-- --:--:-- 619k
[dsw@c1502 hbase]$
Looking at findHangingTest.sh, it seems to look for "Forking command line" which I do not see, though we know this test run times out.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Status: Patch Available (was: Open)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246462#comment-13246462 ]
stack commented on HBASE-5645:
------------------------------
What you think of the hadoopqa failure David? Let me try resubmitting your patch.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251330#comment-13251330 ]
Jonathan Hsieh commented on HBASE-5645:
---------------------------------------
lgtm.
I just checked in HBASE_5653 that reduced the find bugs number, which likely "breaks" this patch. I'm going to submit patch to find out the new number and the tweak v2 to reflect this new number.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246468#comment-13246468 ]
David S. Wang commented on HBASE-5645:
--------------------------------------
I didn't see any actual failures in the results, though the summary says that something failed. Perhaps a bug in the summary code?
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-5645) [findbugs] Fix
correctness warnings
Posted by "Jonathan Hsieh (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251330#comment-13251330 ]
Jonathan Hsieh edited comment on HBASE-5645 at 4/11/12 5:23 AM:
----------------------------------------------------------------
lgtm.
I just checked in HBASE-5653 that reduced the find bugs number, which likely "breaks" this patch. I'm going to submit patch to find out the new number and the tweak v2 to reflect this new number.
was (Author: jmhsieh):
lgtm.
I just checked in HBASE_5653 that reduced the find bugs number, which likely "breaks" this patch. I'm going to submit patch to find out the new number and the tweak v2 to reflect this new number.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251369#comment-13251369 ]
Hadoop QA commented on HBASE-5645:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522212/hbase-5645-2-tweak.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1474//console
This message is automatically generated.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Status: Patch Available (was: Open)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251972#comment-13251972 ]
Hudson commented on HBASE-5645:
-------------------------------
Integrated in HBase-TRUNK #2744 (See [https://builds.apache.org/job/HBase-TRUNK/2744/])
HBASE-5645 [findbugs] Fix correctness warnings (David S Wang and Uma Maheswara Rao G) (Revision 1324969)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/trunk/dev-support/findHangingTest.sh
* /hbase/trunk/dev-support/test-patch.properties
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Fix For: 0.96.0
>
> Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5645:
-------------------------
Status: Patch Available (was: Open)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5645:
-------------------------
Attachment: HBASE-5645.patch
retry
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5645:
-------------------------
Attachment: HBASE-5645.patch
Resubmit of same patch
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250801#comment-13250801 ]
David S. Wang commented on HBASE-5645:
--------------------------------------
TestReplication passed locally for me.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247660#comment-13247660 ]
stack commented on HBASE-5645:
------------------------------
See dev-support/findHangingTest.sh
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247621#comment-13247621 ]
David S. Wang commented on HBASE-5645:
--------------------------------------
OK I did get a timeout locally; I just didn't recognize it. However, I don't know where to get the information about which test timedout. It doesn't report it in the console output, and the surefire-reports stuff just contains the tests that were run to some sort of completion. Is there some place to see what was currently running when the test run timed out?
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246454#comment-13246454 ]
David S. Wang commented on HBASE-5645:
--------------------------------------
Thanks for the review, Stack. Can this be committed now?
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251342#comment-13251342 ]
Uma Maheswara Rao G commented on HBASE-5645:
--------------------------------------------
1) ShutdownHook.java
{code}
if (cache == null) {
throw new RuntimeException(
"This should not happen. Could not find the cache class in FileSystem.");
}
Field field = null;
try {
field = cache.getDeclaredField(CLIENT_FINALIZER_DATA_METHOD);
} catch (NoSuchFieldException e) {
// We can get here if the Cache class does not have a clientFinalizer
// instance: i.e. we're running on straight 0.20 w/o hadoop-4829.
}
{code}
2) In Store.java
{code}
byte[] firstKey = reader.getFirstRowKey();
Preconditions.checkState(firstKey != null, "First key can not be null");
byte[] lk = reader.getLastKey();
Preconditions.checkState(lk != null, "Last key can not be null");
byte[] lastKey = KeyValue.createKeyValueFromKey(lk).getRow();
{code}
We already handled this with preconditions.
3) {code}
int logCount = this.outputfiles == null? 0: this.outputfiles.size();
+ int logCount = this.outputfiles.size();
{code}
This change also already handled by Hbase-5653. So may need to update with latest.
Mostly all are need to resolve the conflicts with fixed and committed changes.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Attachment: HBASE-5645.patch
Run this through the bot.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Status: Patch Available (was: In Progress)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246520#comment-13246520 ]
David S. Wang commented on HBASE-5645:
--------------------------------------
OK I see that the tests timedout. Unfortunately, I cannot tell from the output what test actually timed out. Does anyone know what command I can use locally to try and reproduce this? I didn't see any timeouts when I can "mvn -PrunAllTests test" before but perhaps that is not the right command.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246526#comment-13246526 ]
stack commented on HBASE-5645:
------------------------------
That is the right command. Let me try it here locally.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Attachment: (was: HBASE-5645.patch)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5645:
---------------------------------
Status: Open (was: Patch Available)
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira