You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/24 09:10:40 UTC
[GitHub] [doris] Yulei-Yang opened a new pull request, #15340: [Improvement](S3) support access s3 via temporary security credentials
Yulei-Yang opened a new pull request, #15340:
URL: https://github.com/apache/doris/pull/15340
when creating s3 repo or loading from s3.
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15340:
URL: https://github.com/apache/doris/pull/15340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15340:
URL: https://github.com/apache/doris/pull/15340#discussion_r1057048634
##########
docs/zh-CN/docs/data-operate/import/import-scenes/external-storage-load.md:
##########
@@ -180,3 +180,17 @@ S3 SDK 默认使用 `virtual-hosted style` 方式。但某些对象存储系统
"use_path_style" = "true"
)
```
+
+<version since="1.2"></version>
Review Comment:
标签需要包裹新的内容，比如：
```
<version since="1.2.1">
xxxx
</version>
```
并注意保留前后空行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15340:
URL: https://github.com/apache/doris/pull/15340#issuecomment-1364495208
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15340:
URL: https://github.com/apache/doris/pull/15340#issuecomment-1364540564
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15340:
URL: https://github.com/apache/doris/pull/15340#issuecomment-1364603728
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on a diff in pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
Yulei-Yang commented on code in PR #15340:
URL: https://github.com/apache/doris/pull/15340#discussion_r1057127378
##########
docs/zh-CN/docs/data-operate/import/import-scenes/external-storage-load.md:
##########
@@ -180,3 +180,17 @@ S3 SDK 默认使用 `virtual-hosted style` 方式。但某些对象存储系统
"use_path_style" = "true"
)
```
+
+<version since="1.2"></version>
Review Comment:
fix it in https://github.com/apache/doris/pull/15362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15340:
URL: https://github.com/apache/doris/pull/15340#issuecomment-1364603734
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15340:
URL: https://github.com/apache/doris/pull/15340#issuecomment-1364630270
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.74 seconds
load time: 628 seconds
storage size: 17123123602 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221225054926_clickbench_pr_68299.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15340: [Improvement](S3) support access s3 via temporary security credentials
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15340:
URL: https://github.com/apache/doris/pull/15340#issuecomment-1364495794
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org