[GitHub] [any23] tballison opened a new pull request, #321: ANY23-611 -- general upgrades

["tballison (via GitHub)" <gi...@apache.org>]

tballison opened a new pull request, #321:
URL: https://github.com/apache/any23/pull/321

   Thanks for your contribution to [Apache Any23](https://any23.apache.org/)! Your help is appreciated!
   
   Before opening the pull request, please verify that
   * there is an open issue on the [Any23 issue tracker](https://issues.apache.org/jira/projects/ANY23) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
   * the issue ID (`ANY23-XXXX`)
     - is referenced in the title of the pull request
     - and placed in front of your commit messages surrounded by square brackets (`[ANY23-XXXX] Issue or pull request title`)
   * commits are squashed into a single one (or few commits for larger changes)
   * Java source code follows [formatter-maven-plugin formatting rules](https://code.revelc.net/formatter-maven-plugin/)
   * Any23 is successfully built and unit tests pass by running `mvn clean test`
   * there should be no conflicts when merging the pull request branch into the *recent* master branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled master branch.
   
   We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Any23 in general, please sign up for the [Any23 mailing list](http://any23.apache.org/mailing-lists.html). Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@any23.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [any23] tballison commented on pull request #321: ANY23-611 -- general upgrades

["tballison (via GitHub)" <gi...@apache.org>]

tballison commented on PR #321:
URL: https://github.com/apache/any23/pull/321#issuecomment-1561273463

   This will have to be updated pr #320 .  I'm happy to do so if this seems useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@any23.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [any23] tballison commented on a diff in pull request #321: ANY23-611 -- general upgrades

["tballison (via GitHub)" <gi...@apache.org>]

tballison commented on code in PR #321:
URL: https://github.com/apache/any23/pull/321#discussion_r1204273589


##########
core/src/main/java/org/apache/any23/rdf/Any23ValueFactoryWrapper.java:
##########
@@ -181,6 +182,22 @@ public Literal createLiteral(String pref, IRI value) {
         return wrappedFactory.createLiteral(pref, value);
     }
 

Review Comment:
   I don't know what I'm doing here.  This needs to be reviewed and fixed by someone who does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@any23.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org