You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/22 08:18:41 UTC
Review Request 38600: Introduced a typedef to make consistent use of
case-insentitive http headers easier.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38600/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
Description
-------
Many places in the code were not using case insensitive header names for http. This adds a typedef to make it easier.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2
3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4
3rdparty/libprocess/src/tests/http_tests.cpp d0b9399d38fa284466a012a21080b1d9007af98b
3rdparty/libprocess/src/tests/process_tests.cpp 1023500ac2e3c55be955c4686e7f720eba6b4cc9
Diff: https://reviews.apache.org/r/38600/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38600: Introduced a typedef to make consistent use
of case-insentitive http headers easier.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38600/#review100289
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38600/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Many places in the code were not using case insensitive header names for http. This adds a typedef to make it easier.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2
> 3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4
> 3rdparty/libprocess/src/tests/http_tests.cpp d0b9399d38fa284466a012a21080b1d9007af98b
> 3rdparty/libprocess/src/tests/process_tests.cpp 1023500ac2e3c55be955c4686e7f720eba6b4cc9
>
> Diff: https://reviews.apache.org/r/38600/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38600: Introduced a typedef to make consistent use
of case-insentitive http headers easier.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38600/#review100089
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/http.hpp (line 148)
<https://reviews.apache.org/r/38600/#comment157193>
Nit: `using Headers = ...` to be more C++ 11 ?
- Anand Mazumdar
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38600/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Many places in the code were not using case insensitive header names for http. This adds a typedef to make it easier.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2
> 3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4
> 3rdparty/libprocess/src/tests/http_tests.cpp d0b9399d38fa284466a012a21080b1d9007af98b
> 3rdparty/libprocess/src/tests/process_tests.cpp 1023500ac2e3c55be955c4686e7f720eba6b4cc9
>
> Diff: https://reviews.apache.org/r/38600/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>