You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sunny-jain-maersk (via GitHub)" <gi...@apache.org> on 2023/05/10 08:50:22 UTC
[GitHub] [arrow-datafusion] sunny-jain-maersk opened a new pull request, #6318: corrected order of cd command to git checkout
sunny-jain-maersk opened a new pull request, #6318:
URL: https://github.com/apache/arrow-datafusion/pull/6318
git checkout 12.0.0 was erroring due to .git file could not be found
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6318: corrected order of cd command to git checkout
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6318:
URL: https://github.com/apache/arrow-datafusion/pull/6318#discussion_r1189709982
##########
docs/source/user-guide/cli.md:
##########
@@ -100,8 +100,8 @@ this to work.
```bash
git clone https://github.com/apache/arrow-datafusion
-git checkout 12.0.0
cd arrow-datafusion
+git checkout 12.0.0
Review Comment:
I wonder if we can update this to the most recent release while we are at it -- perhaps
```suggestion
git checkout 24.0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6318: corrected order of cd command to git checkout
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6318:
URL: https://github.com/apache/arrow-datafusion/pull/6318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sunny-jain-maersk commented on a diff in pull request #6318: corrected order of cd command to git checkout
Posted by "sunny-jain-maersk (via GitHub)" <gi...@apache.org>.
sunny-jain-maersk commented on code in PR #6318:
URL: https://github.com/apache/arrow-datafusion/pull/6318#discussion_r1189715996
##########
docs/source/user-guide/cli.md:
##########
@@ -100,8 +100,8 @@ this to work.
```bash
git clone https://github.com/apache/arrow-datafusion
-git checkout 12.0.0
cd arrow-datafusion
+git checkout 12.0.0
Review Comment:
Sure no reason to not bump it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org