[jira] [Commented] (MWRAPPER-21) Arbitrary file write during archive extraction ("Zip Slip") in wrapper

["Jorge Solórzano (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MWRAPPER-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484137#comment-17484137 ] 

Jorge Solórzano commented on MWRAPPER-21:
-----------------------------------------

Just for the record, this issue still exists in the maven-wrapper 3.1.0 as it never went into maven-wrapper.git

Yet it should be properly fixed with https://github.com/apache/maven-wrapper/pull/13

Also, please note that this can be a potential security issue https://snyk.io/research/zip-slip-vulnerability

> Arbitrary file write during archive extraction ("Zip Slip") in wrapper
> ----------------------------------------------------------------------
>
>                 Key: MWRAPPER-21
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-21
>             Project: Maven Wrapper
>          Issue Type: Bug
>          Components: Maven Wrapper Jar
>            Reporter: Sylwester Lachiewicz
>            Assignee: Robert Scholte
>            Priority: Major
>
> In Maven Wrapper Installer [https://github.com/apache/maven/blob/ef8c95eb397651e10f677763dfcd9c8cea7c27b0/maven-wrapper/src/main/java/org/apache/maven/wrapper/Installer.java]
>   
> {code:java}
>  ZipEntry entry = entries.nextElement();
>  if ( entry.isDirectory() )
>  {
>   continue;
>  }
>  Path targetFile = dest.resolve( entry.getName() );
> // Unsanitized archive entry, which may contain '..', is used in a file system operation.
>   // prevent Zip Slip
> if ( targetFile.startsWith( dest ) ) 
> {
>    Files.createDirectories( targetFile.getParent() );
>    Files.copy( zipFile.getInputStream( entry ), targetFile );
> }
> {code}
>  
>  Found via LGTM.com scan



--
This message was sent by Atlassian Jira
(v8.20.1#820001)