You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 17:03:01 UTC
[GitHub] [arrow] alamb opened a new pull request #9129: ARROW-11169: [Rust] Add a comment explaining where float total_order algorithm came from
alamb opened a new pull request #9129:
URL: https://github.com/apache/arrow/pull/9129
Follow up from https://github.com/apache/arrow/pull/8882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9129: ARROW-11169: [Rust] Add a comment explaining where float total_order algorithm came from
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9129:
URL: https://github.com/apache/arrow/pull/9129#issuecomment-756250552
https://issues.apache.org/jira/browse/ARROW-11169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #9129: ARROW-11169: [Rust] Add a comment explaining where float total_order algorithm came from
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #9129:
URL: https://github.com/apache/arrow/pull/9129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #9129: ARROW-11169: [Rust] Add a comment explaining where float total_order algorithm came from
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #9129:
URL: https://github.com/apache/arrow/pull/9129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9129: ARROW-11169: [Rust] Add a comment explaining where float total_order algorithm came from
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9129:
URL: https://github.com/apache/arrow/pull/9129#issuecomment-756259667
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9129?src=pr&el=h1) Report
> Merging [#9129](https://codecov.io/gh/apache/arrow/pull/9129?src=pr&el=desc) (b218e4e) into [master](https://codecov.io/gh/apache/arrow/commit/3ed90f68a77599cc9b7d210b4c5c15b3a59a0545?el=desc) (3ed90f6) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9129?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9129 +/- ##
==========================================
- Coverage 82.59% 82.59% -0.01%
==========================================
Files 204 204
Lines 50542 50542
==========================================
- Hits 41745 41744 -1
- Misses 8797 8798 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9129?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow/pull/9129/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3NvcnQucnM=) | `93.56% <ø> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9129/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9129?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9129?src=pr&el=footer). Last update [3ed90f6...b218e4e](https://codecov.io/gh/apache/arrow/pull/9129?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on a change in pull request #9129: ARROW-11169: [Rust] Add a comment explaining where float total_order algorithm came from
Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #9129:
URL: https://github.com/apache/arrow/pull/9129#discussion_r553473279
##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -42,6 +42,8 @@ pub fn sort(values: &ArrayRef, options: Option<SortOptions>) -> Result<ArrayRef>
}
// sorts f32 in IEEE 754 total ordering
Review comment:
Maybe "sorts" wasn't also the best way to describe it. Maybe `implements comparison using IEEE 754 total ordering`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org