[jira] [Commented] (SLING-7359) DistributionEventDistributeDistributionTrigger causes distribution loop

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315307#comment-16315307 ] 

ASF GitHub Bot commented on SLING-7359:
---------------------------------------

Buuhuu opened a new pull request #3: SLING-7359: prevent distribution loop in triggers from distribution events
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/3
 
 
   This is done by exposing information of the trigger.DispatcherRequestHandler to the trigger implementations, which allow them to filter events they are handling. The DistributionEventDistributeDistributionTrigger has been changed to not propagate events to the handler which have there origin at the handler's owner itself. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DistributionEventDistributeDistributionTrigger causes distribution loop
> -----------------------------------------------------------------------
>
>                 Key: SLING-7359
>                 URL: https://issues.apache.org/jira/browse/SLING-7359
>             Project: Sling
>          Issue Type: Bug
>          Components: Content Distribution
>    Affects Versions: Content Distribution Core 0.2.10
>            Reporter: Dirk Rudolph
>
> The DistributionEventDistributeDistributionTrigger [is listening for org/apache/sling/distribution/agent/package/distributed events|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/trigger/impl/DistributionEventDistributeDistributionTrigger.java#L67]. So assuming we have a agent configured for the allowed root path /foo and trigger for /foo as well, the agent's successful delivery will trigger another distribution on the same agent. 
> To circumvent that the DistributionEventDistributeDistributionTrigger should check the DistributionRequestHandler against the component that fired the event it handles and should stop propagation when the event's origin is the same request handler. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)