You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/18 05:01:00 UTC

[PR] security: reject offset message IDs outside the selected broker topology [rocketmq-dashboard]

Aias00 opened a new pull request, #2339:
URL: https://github.com/apache/rocketmq-dashboard/pull/2339

   Closes #2337
   
   ## Summary
   
   - resolve the broker address embedded in offset-style message IDs
   - verify it belongs to the selected instance broker topology before invoking RocketMQ remoting
   - cover rejected unknown endpoints for message query and trace timestamp lookup
   
   ## Verification
   
   - `mvn -f server/pom.xml -Dtest=RocketMQMessageProviderTest test`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] security: reject offset message IDs outside the selected broker topology [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on code in PR #2339:
URL: https://github.com/apache/rocketmq-dashboard/pull/2339#discussion_r3801316834


##########
server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQMessageProvider.java:
##########
@@ -170,6 +171,51 @@ private MessageExt viewMessageByOffsetId(DefaultMQAdminExt adminExt, String topi
         }
     }
 
+    private String validatedBrokerAddr(DefaultMQAdminExt adminExt, String msgId, MessageId messageId) throws Exception {

Review Comment:
   **[Info]** `validatedBrokerAddr` correctly rejects decoded broker addresses that are not in the known broker topology — a clean SSRF mitigation for the offset-based message view path. The `knownBrokerEndpoints` cache (keyed by adminExt instance) is a good optimization to avoid repeated cluster-info queries within the same request scope.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] security: reject offset message IDs outside the selected broker topology [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #2339:
URL: https://github.com/apache/rocketmq-dashboard/pull/2339#issuecomment-5328973080

   ⚠️ **Merge conflict detected**
   
   This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
   
   ```bash
   git fetch origin
   git checkout fix/studio-validate-message-id-broker
   git rebase origin/develop
   # resolve conflicts, then:
   git push --force-with-lease
   ```
   
   This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
   
   ---
   *Automated notification by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(security): reject offset message IDs outside the selected broker topology [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #2339:
URL: https://github.com/apache/rocketmq-dashboard/pull/2339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org