You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/10 11:55:59 UTC

[GitHub] [pulsar] tongsucn opened a new issue #7502: CPP client compilation issues.

tongsucn opened a new issue #7502:
URL: https://github.com/apache/pulsar/issues/7502


   **Describe the bug**
   
   When enabling `-Wall`, the library cannot be successfully compiled:
   
   1. Non-virtual destructor in base class: `pulsar-client-cpp/lib/auth/AuthOauth2.h:47:7: error: base class 'class pulsar::CachedToken' has accessible non-virtual destructor [-Werror=non-virtual-dtor]`.
   2. Unnecessary NULL checking on function pointer: `/pulsar-client-cpp/lib/ClientImpl.cc:100:10: error: the address of 'pulsar::Logger* logger()' will never be NULL [-Werror=address]`.
   
   **To Reproduce**
   
   Compile with `-Wall`.
   
   **Desktop (please complete the following information):**
    - OS: Linux
    - Compiler: GCC 7.3
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] smazurov edited a comment on issue #7502: CPP client compilation issues.

Posted by GitBox <gi...@apache.org>.
smazurov edited a comment on issue #7502:
URL: https://github.com/apache/pulsar/issues/7502#issuecomment-683096283


   #2 is simply wrong and can be null. GCC needs to get its act together :)
   
   Edit: actually it can be, but it should be checking for !loggerFactory instead..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] smazurov commented on issue #7502: CPP client compilation issues.

Posted by GitBox <gi...@apache.org>.
smazurov commented on issue #7502:
URL: https://github.com/apache/pulsar/issues/7502#issuecomment-683096283


   #2 is simply wrong and can be null. GCC needs to get its act together :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat closed issue #7502: CPP client compilation issues.

Posted by GitBox <gi...@apache.org>.
merlimat closed issue #7502:
URL: https://github.com/apache/pulsar/issues/7502


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org