You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by kn...@apache.org on 2016/11/10 18:05:16 UTC
svn commit: r1769172 - in /pig/trunk: CHANGES.txt
src/org/apache/pig/newplan/logical/rules/AddForEach.java
test/org/apache/pig/test/TestNewPlanColumnPrune.java
Author: knoguchi
Date: Thu Nov 10 18:05:16 2016
New Revision: 1769172
URL: http://svn.apache.org/viewvc?rev=1769172&view=rev
Log:
PIG-5055: Infinite loop with join by fixed index (knoguchi)
Modified:
pig/trunk/CHANGES.txt
pig/trunk/src/org/apache/pig/newplan/logical/rules/AddForEach.java
pig/trunk/test/org/apache/pig/test/TestNewPlanColumnPrune.java
Modified: pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/trunk/CHANGES.txt?rev=1769172&r1=1769171&r2=1769172&view=diff
==============================================================================
--- pig/trunk/CHANGES.txt (original)
+++ pig/trunk/CHANGES.txt Thu Nov 10 18:05:16 2016
@@ -59,6 +59,8 @@ OPTIMIZATIONS
BUG FIXES
+PIG-5055: Infinite loop with join by fixed index (knoguchi)
+
PIG-5049: Cleanup e2e tests turing_jython.conf (Daniel Dai)
PIG-5033: MultiQueryOptimizerTez creates bad plan with union, split and FRJoin (rohini,tmwoordruff via rohini)
Modified: pig/trunk/src/org/apache/pig/newplan/logical/rules/AddForEach.java
URL: http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/newplan/logical/rules/AddForEach.java?rev=1769172&r1=1769171&r2=1769172&view=diff
==============================================================================
--- pig/trunk/src/org/apache/pig/newplan/logical/rules/AddForEach.java (original)
+++ pig/trunk/src/org/apache/pig/newplan/logical/rules/AddForEach.java Thu Nov 10 18:05:16 2016
@@ -95,7 +95,7 @@ public class AddForEach extends WholePla
}
Set<Long> outputUids = (Set<Long>)op.getAnnotation(ColumnPruneHelper.OUTPUTUIDS);
- if (outputUids==null)
+ if (outputUids==null || outputUids.size() == 0 )
return false;
LogicalSchema schema = op.getSchema();
Modified: pig/trunk/test/org/apache/pig/test/TestNewPlanColumnPrune.java
URL: http://svn.apache.org/viewvc/pig/trunk/test/org/apache/pig/test/TestNewPlanColumnPrune.java?rev=1769172&r1=1769171&r2=1769172&view=diff
==============================================================================
--- pig/trunk/test/org/apache/pig/test/TestNewPlanColumnPrune.java (original)
+++ pig/trunk/test/org/apache/pig/test/TestNewPlanColumnPrune.java Thu Nov 10 18:05:16 2016
@@ -454,6 +454,34 @@ public class TestNewPlanColumnPrune {
}
}
+ @Test
+ public void testNoAddForeach() throws Exception {
+ // PIG-5055
+ // Need to make sure that it does not add foreach
+ // that drops all the fields from B2.
+ String query = "A = load 'd.txt' as (a0:int, a1:int, a2:int);" +
+ "B = load 'd.txt' as (b0:int, b1:int, b2:int);" +
+ "B2 = FILTER B by b0 == 0;" +
+ "C = join A by (1), B2 by (1) ;" +
+ "D = FOREACH C GENERATE A::a1, A::a2;" +
+ "store D into 'empty';";
+
+ LogicalPlan newLogicalPlan = buildPlan(query);
+
+ PlanOptimizer optimizer = new MyPlanOptimizer(newLogicalPlan, 3);
+ optimizer.optimize();
+ System.err.println(newLogicalPlan);
+ Iterator<Operator> iter = newLogicalPlan.getOperators();
+ while (iter.hasNext()) {
+ Operator o = iter.next();
+ LogicalRelationalOperator lro = (LogicalRelationalOperator)o;
+ if (lro == null || lro.getAlias() == null) continue;
+ if (lro.getAlias().equals("B2")) {
+ assertNotNull(lro.getSchema());
+ }
+ }
+ }
+
public class MyPlanOptimizer extends LogicalPlanOptimizer {
protected MyPlanOptimizer(OperatorPlan p, int iterations) {