Re: [PR] [DO NOT MERGE] Attempt to fix Toaster in Plugin [airflow]

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi commented on code in PR #55641:
URL: https://github.com/apache/airflow/pull/55641#discussion_r2830403063


##########
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/ui/toaster.tsx:
##########
@@ -16,9 +16,29 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { createToaster } from "@chakra-ui/react";
+import { Toaster as ChakraToaster, Portal, Spinner, Stack, Toast, createToaster } from "@chakra-ui/react";
 
 export const toaster = createToaster({
   pauseOnPageIdle: true,
   placement: "bottom-end",
 });
+
+export const Toaster = () => {
+  return (
+    <Portal>

Review Comment:
   You need to pass a containerRef to this portal.
   `  const portalContainerRef = useRef<HTMLDivElement>(null);`
   ` <div ref={portalContainerRef}>{APP}</div>`
   `  <Portal containerRef={containerRef}>`
   
   It just needs to be a random div in main.tsx
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org