You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "win120a (via GitHub)" <gi...@apache.org> on 2023/04/04 11:06:30 UTC
[GitHub] [dubbo-samples] win120a opened a new pull request, #810: Change some legacy pacakge usage (com.alibaba.dubbo) to the present one.
win120a opened a new pull request, #810:
URL: https://github.com/apache/dubbo-samples/pull/810
Some examples uses legacy package name `com.alibaba.dubbo`, which is for backward-compatible only and deprecated. This PR changes that to `org.apache.dubbo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #810: Change some legacy package usage (com.alibaba.dubbo) to the present one.
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #810:
URL: https://github.com/apache/dubbo-samples/pull/810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] win120a commented on pull request #810: Change some legacy package usage (com.alibaba.dubbo) to the present one.
Posted by "win120a (via GitHub)" <gi...@apache.org>.
win120a commented on PR #810:
URL: https://github.com/apache/dubbo-samples/pull/810#issuecomment-1502820258
@AlbumenJ Any progress about this and https://github.com/apache/dubbo/pull/12018 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] win120a commented on pull request #810: Change some legacy package usage (com.alibaba.dubbo) to the present one.
Posted by "win120a (via GitHub)" <gi...@apache.org>.
win120a commented on PR #810:
URL: https://github.com/apache/dubbo-samples/pull/810#issuecomment-1505477506
> > @AlbumenJ Any progress about this and [apache/dubbo#12018](https://github.com/apache/dubbo/pull/12018) ?
>
> We should consider how to deep copy apache RpcException to a new exception extends alibaba RpcEecetion. But I haven't figured out how to do it yet.
So... For this PR, I will revert the changes of `3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/TriGenericTest.java` (which causes the problem) temporarily. Maybe we can discuss about that later by filing an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] win120a commented on pull request #810: Change some legacy package usage (com.alibaba.dubbo) to the present one.
Posted by "win120a (via GitHub)" <gi...@apache.org>.
win120a commented on PR #810:
URL: https://github.com/apache/dubbo-samples/pull/810#issuecomment-1505468235
> > @AlbumenJ Any progress about this and [apache/dubbo#12018](https://github.com/apache/dubbo/pull/12018) ?
>
> We should consider how to deep copy apache RpcException to a new exception extends alibaba RpcEecetion. But I haven't figured out how to do it yet.
So... For this PR, I will revert the changes of `3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/TriGenericTest.java` (which cause the problem) temporarily. Maybe we can discuss about that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ commented on pull request #810: Change some legacy package usage (com.alibaba.dubbo) to the present one.
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #810:
URL: https://github.com/apache/dubbo-samples/pull/810#issuecomment-1505109786
> @AlbumenJ Any progress about this and [apache/dubbo#12018](https://github.com/apache/dubbo/pull/12018) ?
We should consider how to deep copy apache RpcException to a new exception extends alibaba RpcEecetion. But I haven't figured out how to do it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org