You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@asterixdb.apache.org by Till Westmann <ti...@apache.org> on 2016/10/02 01:21:27 UTC
Location of test results
Hi,
in a recent change [1] the test result location changed from "a
directory in
the module folder" to "a directory in the target folder". So now
a) the test results will get removed with every "mvn clean" and
b) we don’t need to exclude the test result directories in .gitignore
anymore.
Both of those seem to be good effects.
However, this change wasn’t announced to anybody (I saw it in a
review,
but didn’t think about it too much) and so in the latest change [2] we
added
the result directories again (probably because those directories were
still
around and showing up in "git status").
I think that moving the test results to the target directory was a good
step
and that
1) everybody should remove the old result locations from their local
trees
and
2) we should remove those directories from .gitignore again.
Thoughts? Concerns? Better ideas?
Cheers,
Till
[1]
https://github.com/apache/asterixdb/commit/e4b318f650379daa8b3c6fc133ee5f7c5bcafc41
[2]
https://github.com/apache/asterixdb/commit/6f7c5312d46b4d1ad22123821b6cd589d3c88413
Re: Location of test results
Posted by Taewoo Kim <wa...@gmail.com>.
+1
Best,
Taewoo
On Sat, Oct 1, 2016 at 6:48 PM, Chris Hillery <ch...@hillery.land> wrote:
> +1.
> Ceej
>
> On Oct 1, 2016 6:30 PM, "Yingyi Bu" <bu...@gmail.com> wrote:
>
> > +1.
> >
> > Best,
> > Yingyi
> >
> > On Sat, Oct 1, 2016 at 6:21 PM, Till Westmann <ti...@apache.org> wrote:
> >
> > > Hi,
> > >
> > > in a recent change [1] the test result location changed from "a
> directory
> > > in
> > > the module folder" to "a directory in the target folder". So now
> > > a) the test results will get removed with every "mvn clean" and
> > > b) we don’t need to exclude the test result directories in .gitignore
> > > anymore.
> > > Both of those seem to be good effects.
> > > However, this change wasn’t announced to anybody (I saw it in a review,
> > > but didn’t think about it too much) and so in the latest change [2] we
> > > added
> > > the result directories again (probably because those directories were
> > still
> > > around and showing up in "git status").
> > >
> > > I think that moving the test results to the target directory was a good
> > > step
> > > and that
> > > 1) everybody should remove the old result locations from their local
> > trees
> > > and
> > > 2) we should remove those directories from .gitignore again.
> > >
> > > Thoughts? Concerns? Better ideas?
> > >
> > > Cheers,
> > > Till
> > >
> > > [1] https://github.com/apache/asterixdb/commit/e4b318f650379daa8
> > > b3c6fc133ee5f7c5bcafc41
> > > [2] https://github.com/apache/asterixdb/commit/6f7c5312d46b4d1ad
> > > 22123821b6cd589d3c88413
> > >
> >
>
Re: Location of test results
Posted by Mike Carey <dt...@gmail.com>.
+1
On 10/1/16 6:48 PM, Chris Hillery wrote:
> +1.
> Ceej
>
> On Oct 1, 2016 6:30 PM, "Yingyi Bu" <bu...@gmail.com> wrote:
>
>> +1.
>>
>> Best,
>> Yingyi
>>
>> On Sat, Oct 1, 2016 at 6:21 PM, Till Westmann <ti...@apache.org> wrote:
>>
>>> Hi,
>>>
>>> in a recent change [1] the test result location changed from "a directory
>>> in
>>> the module folder" to "a directory in the target folder". So now
>>> a) the test results will get removed with every "mvn clean" and
>>> b) we don\u2019t need to exclude the test result directories in .gitignore
>>> anymore.
>>> Both of those seem to be good effects.
>>> However, this change wasn\u2019t announced to anybody (I saw it in a review,
>>> but didn\u2019t think about it too much) and so in the latest change [2] we
>>> added
>>> the result directories again (probably because those directories were
>> still
>>> around and showing up in "git status").
>>>
>>> I think that moving the test results to the target directory was a good
>>> step
>>> and that
>>> 1) everybody should remove the old result locations from their local
>> trees
>>> and
>>> 2) we should remove those directories from .gitignore again.
>>>
>>> Thoughts? Concerns? Better ideas?
>>>
>>> Cheers,
>>> Till
>>>
>>> [1] https://github.com/apache/asterixdb/commit/e4b318f650379daa8
>>> b3c6fc133ee5f7c5bcafc41
>>> [2] https://github.com/apache/asterixdb/commit/6f7c5312d46b4d1ad
>>> 22123821b6cd589d3c88413
>>>
Re: Location of test results
Posted by Chris Hillery <ch...@hillery.land>.
+1.
Ceej
On Oct 1, 2016 6:30 PM, "Yingyi Bu" <bu...@gmail.com> wrote:
> +1.
>
> Best,
> Yingyi
>
> On Sat, Oct 1, 2016 at 6:21 PM, Till Westmann <ti...@apache.org> wrote:
>
> > Hi,
> >
> > in a recent change [1] the test result location changed from "a directory
> > in
> > the module folder" to "a directory in the target folder". So now
> > a) the test results will get removed with every "mvn clean" and
> > b) we don’t need to exclude the test result directories in .gitignore
> > anymore.
> > Both of those seem to be good effects.
> > However, this change wasn’t announced to anybody (I saw it in a review,
> > but didn’t think about it too much) and so in the latest change [2] we
> > added
> > the result directories again (probably because those directories were
> still
> > around and showing up in "git status").
> >
> > I think that moving the test results to the target directory was a good
> > step
> > and that
> > 1) everybody should remove the old result locations from their local
> trees
> > and
> > 2) we should remove those directories from .gitignore again.
> >
> > Thoughts? Concerns? Better ideas?
> >
> > Cheers,
> > Till
> >
> > [1] https://github.com/apache/asterixdb/commit/e4b318f650379daa8
> > b3c6fc133ee5f7c5bcafc41
> > [2] https://github.com/apache/asterixdb/commit/6f7c5312d46b4d1ad
> > 22123821b6cd589d3c88413
> >
>
Re: Location of test results
Posted by Yingyi Bu <bu...@gmail.com>.
+1.
Best,
Yingyi
On Sat, Oct 1, 2016 at 6:21 PM, Till Westmann <ti...@apache.org> wrote:
> Hi,
>
> in a recent change [1] the test result location changed from "a directory
> in
> the module folder" to "a directory in the target folder". So now
> a) the test results will get removed with every "mvn clean" and
> b) we don’t need to exclude the test result directories in .gitignore
> anymore.
> Both of those seem to be good effects.
> However, this change wasn’t announced to anybody (I saw it in a review,
> but didn’t think about it too much) and so in the latest change [2] we
> added
> the result directories again (probably because those directories were still
> around and showing up in "git status").
>
> I think that moving the test results to the target directory was a good
> step
> and that
> 1) everybody should remove the old result locations from their local trees
> and
> 2) we should remove those directories from .gitignore again.
>
> Thoughts? Concerns? Better ideas?
>
> Cheers,
> Till
>
> [1] https://github.com/apache/asterixdb/commit/e4b318f650379daa8
> b3c6fc133ee5f7c5bcafc41
> [2] https://github.com/apache/asterixdb/commit/6f7c5312d46b4d1ad
> 22123821b6cd589d3c88413
>
Re: Location of test results
Posted by abdullah alamoudi <ba...@gmail.com>.
+1
Cheers,
~Abdullah.
> On Oct 2, 2016, at 4:21 AM, Till Westmann <ti...@apache.org> wrote:
>
> Hi,
>
> in a recent change [1] the test result location changed from "a directory in
> the module folder" to "a directory in the target folder". So now
> a) the test results will get removed with every "mvn clean" and
> b) we don’t need to exclude the test result directories in .gitignore
> anymore.
> Both of those seem to be good effects.
> However, this change wasn’t announced to anybody (I saw it in a review,
> but didn’t think about it too much) and so in the latest change [2] we added
> the result directories again (probably because those directories were still
> around and showing up in "git status").
>
> I think that moving the test results to the target directory was a good step
> and that
> 1) everybody should remove the old result locations from their local trees
> and
> 2) we should remove those directories from .gitignore again.
>
> Thoughts? Concerns? Better ideas?
>
> Cheers,
> Till
>
> [1] https://github.com/apache/asterixdb/commit/e4b318f650379daa8b3c6fc133ee5f7c5bcafc41
> [2] https://github.com/apache/asterixdb/commit/6f7c5312d46b4d1ad22123821b6cd589d3c88413