You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kanzhe Jiang <ka...@bigswitch.com> on 2013/03/07 00:39:06 UTC

Review Request: Remove VNS isolation option from UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9787/
-----------------------------------------------------------

Review request for cloudstack and Chiradeep Vittal.


Description
-------

The updated BigSwitch plugin patch didn't make into 4.1. Remove the VNS option from 4.1 UI.
The plugin will be in 4.2.


This addresses bug 1345.


Diffs
-----

  ui/scripts/ui-custom/zoneWizard.js 718b454 

Diff: https://reviews.apache.org/r/9787/diff/


Testing
-------

Launched the UI and confirmed the VNS is removed from isolation method in addZone wizard.


Thanks,

Kanzhe Jiang


Re: Review Request: Remove VNS isolation option from UI

Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9787/#review17561
-----------------------------------------------------------

Ship it!


builds fine

- Chiradeep Vittal


On March 6, 2013, 11:39 p.m., Kanzhe Jiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9787/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 11:39 p.m.)
> 
> 
> Review request for cloudstack and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> The updated BigSwitch plugin patch didn't make into 4.1. Remove the VNS option from 4.1 UI.
> The plugin will be in 4.2.
> 
> 
> This addresses bug 1345.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/ui-custom/zoneWizard.js 718b454 
> 
> Diff: https://reviews.apache.org/r/9787/diff/
> 
> 
> Testing
> -------
> 
> Launched the UI and confirmed the VNS is removed from isolation method in addZone wizard.
> 
> 
> Thanks,
> 
> Kanzhe Jiang
> 
>


Re: Review Request: Remove VNS isolation option from UI

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9787/#review17563
-----------------------------------------------------------

Ship it!


Thanks for the patch!

Applied to 4.1:

commit 06e7fc1117cefc3cbee9f29d9c1d8f66de4cf0a5
Author: Kanzhe Jiang <ka...@bigswitch.com>
Date:   Wed Mar 6 15:33:55 2013 -0800

    CLOUDSTACK-1345, remove VNS from UI

- Chip Childers


On March 6, 2013, 11:39 p.m., Kanzhe Jiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9787/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 11:39 p.m.)
> 
> 
> Review request for cloudstack and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> The updated BigSwitch plugin patch didn't make into 4.1. Remove the VNS option from 4.1 UI.
> The plugin will be in 4.2.
> 
> 
> This addresses bug 1345.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/ui-custom/zoneWizard.js 718b454 
> 
> Diff: https://reviews.apache.org/r/9787/diff/
> 
> 
> Testing
> -------
> 
> Launched the UI and confirmed the VNS is removed from isolation method in addZone wizard.
> 
> 
> Thanks,
> 
> Kanzhe Jiang
> 
>