[GitHub] [tvm] areusch commented on a change in pull request #8075: [microTVM] AOT Demo

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #8075:
URL: https://github.com/apache/tvm/pull/8075#discussion_r635658205



##########
File path: apps/microtvm/zephyr/demo_runtime/boards/nrf5340dk_nrf5340_cpuapp.conf
##########
@@ -21,7 +21,7 @@
 CONFIG_CMSIS_DSP=y
 
 # Required for Cortex-M33 devices.
-CONFIG_MAIN_STACK_SIZE=1536

Review comment:
       i don't think we should mess with these now--we should keep them as minimal as possible under _some_ runtime configuration. maybe we can create AOT versions which can be selected with an option? after we have project generator, it should be easy to customize these.
   
   it also might be easiest, considering the other changes, to just create `apps/microtvm/aot_demo`.

##########
File path: apps/microtvm/zephyr/demo_runtime/CMakeLists.txt
##########
@@ -10,8 +10,17 @@ find_package(Zephyr HINTS $ENV{ZEPHYR_BASE})
 project(microtvm_zephyr_runtime)
 
 set(CMAKE_VERBOSE_MAKEFILE ON)
-file(GLOB TVM_SOURCES ${CMAKE_SOURCE_DIR}/__tvm*.c)
-target_sources(app PRIVATE src/main.c ${TVM_SOURCES})
+
+if($ENV{ZEPHYR_RUNTIME} STREQUAL "HOST-DRIVEN")

Review comment:
       if we create a separate project, let's get rid of this env var




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org