You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2012/08/29 13:35:07 UTC
[jira] [Created] (AMQ-4003) Add option to PooledConnectionFactory
to control if connection should be created on startup or not
Claus Ibsen created AMQ-4003:
--------------------------------
Summary: Add option to PooledConnectionFactory to control if connection should be created on startup or not
Key: AMQ-4003
URL: https://issues.apache.org/jira/browse/AMQ-4003
Project: ActiveMQ
Issue Type: Improvement
Affects Versions: 5.6.0
Reporter: Claus Ibsen
Priority: Minor
Fix For: 5.7.0
Attachments: AMQ-4003.patch
The PooledConnectionFactory will currently always on startup create a connection, and if that fails a WARN is logged and ignored.
I think we should allow end users to configure if they want the pool to create a connection on startup or not.
If they set the option to false, then the connection is created on-demand.
I have attached a patch with this option, using a default value of true to keep current behavior. The patch also adds some more logging, as well removing some not needed code, in the start method, ie the IOExceptionSupport that don't make sense.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4003) Add option to PooledConnectionFactory
to control if connection should be created on startup or not
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated AMQ-4003:
-----------------------------
Attachment: AMQ-4003.patch
> Add option to PooledConnectionFactory to control if connection should be created on startup or not
> --------------------------------------------------------------------------------------------------
>
> Key: AMQ-4003
> URL: https://issues.apache.org/jira/browse/AMQ-4003
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.6.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 5.7.0
>
> Attachments: AMQ-4003.patch
>
>
> The PooledConnectionFactory will currently always on startup create a connection, and if that fails a WARN is logged and ignored.
> I think we should allow end users to configure if they want the pool to create a connection on startup or not.
> If they set the option to false, then the connection is created on-demand.
> I have attached a patch with this option, using a default value of true to keep current behavior. The patch also adds some more logging, as well removing some not needed code, in the start method, ie the IOExceptionSupport that don't make sense.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4003) Add option to PooledConnectionFactory
to control if connection should be created on startup or not
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated AMQ-4003:
-----------------------------
Component/s: activemq-pool
> Add option to PooledConnectionFactory to control if connection should be created on startup or not
> --------------------------------------------------------------------------------------------------
>
> Key: AMQ-4003
> URL: https://issues.apache.org/jira/browse/AMQ-4003
> Project: ActiveMQ
> Issue Type: Improvement
> Components: activemq-pool
> Affects Versions: 5.6.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.7.0
>
> Attachments: AMQ-4003.patch
>
>
> The PooledConnectionFactory will currently always on startup create a connection, and if that fails a WARN is logged and ignored.
> I think we should allow end users to configure if they want the pool to create a connection on startup or not.
> If they set the option to false, then the connection is created on-demand.
> I have attached a patch with this option, using a default value of true to keep current behavior. The patch also adds some more logging, as well removing some not needed code, in the start method, ie the IOExceptionSupport that don't make sense.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4003) Add option to PooledConnectionFactory
to control if connection should be created on startup or not
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444014#comment-13444014 ]
Timothy Bish commented on AMQ-4003:
-----------------------------------
Seems like a reasonable improvement to the code.
> Add option to PooledConnectionFactory to control if connection should be created on startup or not
> --------------------------------------------------------------------------------------------------
>
> Key: AMQ-4003
> URL: https://issues.apache.org/jira/browse/AMQ-4003
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.6.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 5.7.0
>
> Attachments: AMQ-4003.patch
>
>
> The PooledConnectionFactory will currently always on startup create a connection, and if that fails a WARN is logged and ignored.
> I think we should allow end users to configure if they want the pool to create a connection on startup or not.
> If they set the option to false, then the connection is created on-demand.
> I have attached a patch with this option, using a default value of true to keep current behavior. The patch also adds some more logging, as well removing some not needed code, in the start method, ie the IOExceptionSupport that don't make sense.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-4003) Add option to PooledConnectionFactory
to control if connection should be created on startup or not
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved AMQ-4003.
------------------------------
Resolution: Fixed
Assignee: Claus Ibsen
Applied patch to trunk
> Add option to PooledConnectionFactory to control if connection should be created on startup or not
> --------------------------------------------------------------------------------------------------
>
> Key: AMQ-4003
> URL: https://issues.apache.org/jira/browse/AMQ-4003
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.6.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.7.0
>
> Attachments: AMQ-4003.patch
>
>
> The PooledConnectionFactory will currently always on startup create a connection, and if that fails a WARN is logged and ignored.
> I think we should allow end users to configure if they want the pool to create a connection on startup or not.
> If they set the option to false, then the connection is created on-demand.
> I have attached a patch with this option, using a default value of true to keep current behavior. The patch also adds some more logging, as well removing some not needed code, in the start method, ie the IOExceptionSupport that don't make sense.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira