You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Kihwal Lee (JIRA)" <ji...@apache.org> on 2012/08/28 18:56:07 UTC
[jira] [Created] (HDFS-3861) Deadlock in DFSClient
Kihwal Lee created HDFS-3861:
--------------------------------
Summary: Deadlock in DFSClient
Key: HDFS-3861
URL: https://issues.apache.org/jira/browse/HDFS-3861
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
Reporter: Kihwal Lee
Priority: Blocker
Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-3861) Deadlock in DFSClient
Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kihwal Lee reassigned HDFS-3861:
--------------------------------
Assignee: Kihwal Lee
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3861) Deadlock in DFSClient
Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kihwal Lee updated HDFS-3861:
-----------------------------
Attachment: hdfs-3861.patch.txt
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3861) Deadlock in DFSClient
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445949#comment-13445949 ]
Hudson commented on HDFS-3861:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1182 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1182/])
HDFS-3861. Deadlock in DFSClient (Kihwal Lee via daryn) (Revision 1379093)
Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379093
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3861) Deadlock in DFSClient
Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kihwal Lee updated HDFS-3861:
-----------------------------
Status: Patch Available (was: Open)
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HDFS-3861) Deadlock in DFSClient
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HDFS-3861.
-------------------------------
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 0.23.3, 3.0.0, 2.0.2-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.3, 2.0.2-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3861) Deadlock in DFSClient
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445894#comment-13445894 ]
Hudson commented on HDFS-3861:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1151 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1151/])
HDFS-3861. Deadlock in DFSClient (Kihwal Lee via daryn) (Revision 1379093)
Result = FAILURE
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379093
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3861) Deadlock in DFSClient
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443463#comment-13443463 ]
Colin Patrick McCabe commented on HDFS-3861:
--------------------------------------------
Looks good to me.
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3861) Deadlock in DFSClient
Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443401#comment-13443401 ]
Kihwal Lee commented on HDFS-3861:
----------------------------------
- The test failures are not related to this patch.
- No test was added. Existing test case exposed this bug (TestDataNodeDeath).
- The findbugs warning is not caused by this patch.
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3861) Deadlock in DFSClient
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-3861:
-----------------------------------------
Component/s: hdfs client
Hadoop Flags: Reviewed
+1 patch looks good. Thanks for fixing this.
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3861) Deadlock in DFSClient
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445876#comment-13445876 ]
Hudson commented on HDFS-3861:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #360 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/360/])
merge -r 1379092:1379093 from trunk. FIXES: HDFS-3861 (Revision 1379097)
Result = UNSTABLE
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379097
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3861) Deadlock in DFSClient
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HDFS-3861:
------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.23.4)
0.23.3
Target Version/s: 0.23.3, 3.0.0, 2.2.0-alpha
Status: Resolved (was: Patch Available)
Thanks Kihwal!
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3861) Deadlock in DFSClient
Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443269#comment-13443269 ]
Kihwal Lee commented on HDFS-3861:
----------------------------------
DFSClient#getLeaseRenewer() doesn't have to be synchronized since LeaseManager.Factory methods are synchronized. Multiple callers are still guaranteed to get a single live renewer back.
{noformat}
Java stack information for the threads listed above:
===================================================
"Thread-28":
at
org.apache.hadoop.hdfs.DFSOutputStream.close(DFSOutputStream.java:1729)
- waiting to lock <0xb5a05dc8> (a
org.apache.hadoop.hdfs.DFSOutputStream)
at
org.apache.hadoop.hdfs.DFSClient.closeAllFilesBeingWritten(DFSClient.java:674)
at org.apache.hadoop.hdfs.DFSClient.close(DFSClient.java:691)
- locked <0xb5a06ed8> (a org.apache.hadoop.hdfs.DFSClient)
at
org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:539)
at org.apache.hadoop.fs.FileSystem$Cache.closeAll(FileSystem.java:2386)
- locked <0xb44b00e8> (a org.apache.hadoop.fs.FileSystem$Cache)
at
org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer.run(FileSystem.java:2403)
- locked <0xb44b0100> (a
org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer)
at
org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:54)
"Thread-1175":
at org.apache.hadoop.hdfs.DFSClient.getLeaseRenewer(DFSClient.java:538)
- waiting to lock <0xb5a06ed8> (a org.apache.hadoop.hdfs.DFSClient)
at org.apache.hadoop.hdfs.DFSClient.endFileLease(DFSClient.java:550)
at
org.apache.hadoop.hdfs.DFSOutputStream.close(DFSOutputStream.java:1757)
- locked <0xb5a05dc8> (a org.apache.hadoop.hdfs.DFSOutputStream)
at
org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:66)
at
org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:99)
at
org.apache.hadoop.hdfs.TestDatanodeDeath$Workload.run(TestDatanodeDeath.java:101)
{noformat}
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3861) Deadlock in DFSClient
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443351#comment-13443351 ]
Hadoop QA commented on HDFS-3861:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542787/hdfs-3861.patch.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestHftpDelegationToken
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3109//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3109//console
This message is automatically generated.
> Deadlock in DFSClient
> ---------------------
>
> Key: HDFS-3861
> URL: https://issues.apache.org/jira/browse/HDFS-3861
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 0.23.4, 3.0.0, 2.2.0-alpha
>
> Attachments: hdfs-3861.patch.txt
>
>
> The deadlock is between DFSOutputStream#close() and DFSClient#close().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira