You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2018/09/01 23:44:00 UTC
[jira] [Commented] (CALCITE-2523)
PartiallyOrderedSetTest#testPosetBitsLarge takes ~80 seconds at Travis
[ https://issues.apache.org/jira/browse/CALCITE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599846#comment-16599846 ]
Julian Hyde commented on CALCITE-2523:
--------------------------------------
I wouldn't say useless. It is making sure things don't break.
> PartiallyOrderedSetTest#testPosetBitsLarge takes ~80 seconds at Travis
> ----------------------------------------------------------------------
>
> Key: CALCITE-2523
> URL: https://issues.apache.org/jira/browse/CALCITE-2523
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> PartiallyOrderedSetTest#testPosetBitsLarge is quite large, and it performs exactly the same computation during test execution.
> I suggest to guard the test like {{testPosetBitsLarge2}} with ENABLE_SLOW:
> {code:java}Assume.assumeTrue("too slow to run every day", CalciteAssert.ENABLE_SLOW);{code}
> Alternative options: reduce test complexity to make it faster, and/or randomize test execution so it explores new test cases on every execution. For instance, it could run for 5 seconds and explore new cases each time.
> Current test is more or less useless, and it does take noticeable CI time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)