You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/09 16:32:08 UTC

[GitHub] [beam] apilloud commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

apilloud commented on a change in pull request #12163:
URL: https://github.com/apache/beam/pull/12163#discussion_r452337633



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -182,11 +164,10 @@ ResolvedStatement analyzeNextStatement(
     return resolvedStatement;
   }
 
-  static AnalyzerOptions initAnalyzerOptions() {
+  static AnalyzerOptions baseAnalyzerOptions() {

Review comment:
       nit: I'd prefer if you didn't rename this method, there are a bunch of references to it inside google. (Alternatively please rename the method of the same name in the C++ validator to match.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org