[GitHub] [doris] englefly commented on a diff in pull request #14895: [fix](nereids)add slot desc for order key

[GitBox <gi...@apache.org>]

englefly commented on code in PR #14895:
URL: https://github.com/apache/doris/pull/14895#discussion_r1042839611


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -487,6 +488,24 @@ public PlanFragment visitPhysicalTopN(PhysicalTopN<? extends Plan> topN, PlanTra
         return mergeFragment;
     }
 
+    private List<OrderKey> addAliasForNonSlot(List<OrderKey> orderKeys) {

Review Comment:
   `this.addExprIdSlotRefPair(alias.getExprId(), slotRef);`
   we need an ExprId to link slotRef. 
   there is no exprId in expressions like `k % 5`, that why I wrap it into an alias to get the exprId



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org