You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/05/14 20:01:36 UTC

[GitHub] [calcite] julianhyde commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream

julianhyde commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream
URL: https://github.com/apache/calcite/pull/1127#issuecomment-492387874
 
 
   I don't think a vote is required for a new adapter - it is just a code change, albeit a significant one. That said, I think we should get consensus on the dev list that it's a good idea. It will add to the work load of every future release manager.
   
   I've added some high-level review comments to https://issues.apache.org/jira/browse/CALCITE-2913. I will encourage other committers to make high-level comments in JIRA also. @asereda-gs is doing an excellent job of reviewing line-by-line (thank you Andrei!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services