[GitHub] [druid] AmatyaAvadhanula commented on a diff in pull request #13411: Fix needless task shutdown on leader switch

[GitBox <gi...@apache.org>]

AmatyaAvadhanula commented on code in PR #13411:
URL: https://github.com/apache/druid/pull/13411#discussion_r1029036721


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2014,9 +2014,24 @@ private void resumeAllActivelyReadingTasks()
     }
 
     Map<String, ListenableFuture<Boolean>> tasksToResume = new HashMap<>();
+    if (activelyReadingTaskGroups.isEmpty()) {
+      return;
+    }
+    // Resume only running tasks and not pending / waiting ones.

Review Comment:
   ```
             leaderLifecycle.addManagedInstance(taskRunner);
             leaderLifecycle.addManagedInstance(taskQueue);
             leaderLifecycle.addManagedInstance(supervisorManager);
             leaderLifecycle.addManagedInstance(overlordHelperManager);
   ```
   
   Handlers are added while trying to become the leader and are also processed in this order.
   TaskRunner#start seems to sync its state for both RTR and HRTR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org