[GitHub] [arrow-datafusion] Jefffrey commented on issue #6853: to_string and from_string have different behavior for TableReference

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on issue #6853:
URL: https://github.com/apache/arrow-datafusion/issues/6853#issuecomment-1632390605

   Another option is to replace the code in the display impl with `to_quoted_string()`
   
   https://github.com/apache/arrow-datafusion/blob/d6985b0fc1e4362b80beea059857c6bde65b4d04/datafusion/common/src/table_reference.rs#L269-L297
   
   Which should minimally quote the output identifier string, preserving roundtrip ability between `to_string()` and `from_string()`
   
   >  Thus I propose to make `TableReference` as simple as possible and gather all those `to_lower_cases` and "quotes" before generating the very first `TableReference`.
   
   Could you expand on this point a bit? My only concern is that if an identifier part contains a period `.` then the quotes would still be necessary in the output of `to_string()`, e.g. `catalog."data.base".table`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org