You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by Ramana Radhakrishnan <no...@github.com> on 2019/07/09 12:12:43 UTC

[dmlc/tvm] [RFC] Initial support for Tflite operator SPLIT (#3520)

This patch adds initial support for the tflite operator split. However
I am not yet sure how to handle the axis parameter for the split
operator and support it in the test infrastructure. Putting this up for
an initial review and comment.

The split operator in tflite according to
https://www.tensorflow.org/lite/guide/ops_compatibility

appears to take num_or_size_split as a 0D tensor.

I also note that tflite.split is one of the few operators that returns
multiple outputs and thus the helper routines in the tests needed some
massaging to make this work.

@apivarov , could you please review this ?

Thanks,
Ramana
You can view, comment on, or merge this pull request online at:

  https://github.com/dmlc/tvm/pull/3520

-- Commit Summary --

  * [RFC] Initial support for Tflite operator SPLIT

-- File Changes --

    M python/tvm/relay/frontend/tflite.py (28)
    M tests/python/frontend/tflite/test_forward.py (31)

-- Patch Links --

https://github.com/dmlc/tvm/pull/3520.patch
https://github.com/dmlc/tvm/pull/3520.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/3520

Re: [dmlc/tvm] [RFC] Initial support for Tflite operator SPLIT (#3520)

Posted by Zhao Wu <no...@github.com>.
@u99127 Please help to make the CI green. Seems your op test causes that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/3520#issuecomment-510308397

Re: [dmlc/tvm] [RFC] Initial support for Tflite operator SPLIT (#3520)

Posted by Zhao Wu <no...@github.com>.
@u99127 Could you modify PR as my suggestion? I think it will work now. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/3520#issuecomment-513176720

Re: [dmlc/tvm] [RFC] Initial support for Tflite operator SPLIT (#3520)

Posted by Ramana Radhakrishnan <no...@github.com>.
Thanks for the poke, I've been investigating why it's been failing off and on for a couple of days,  however I don't yet have a gpu environment set up and the failure doesn't happen with the cpu docker script. 

I'm going to be busy for the next couple of days. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/3520#issuecomment-510392482

Re: [dmlc/tvm] [RFC] Initial support for Tflite operator SPLIT (#3520)

Posted by Zhao Wu <no...@github.com>.
Thanks @u99127 LGTM.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/3520#issuecomment-510035031

Re: [dmlc/tvm] [RFC] Initial support for Tflite operator SPLIT (#3520)

Posted by Zhao Wu <no...@github.com>.
Thanks @u99127 LGTM now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/3520#issuecomment-513425857