[jira] [Commented] (YARN-7200) SLS generates a realtimetrack.json file but that file is missing the closing ']'

["Szilard Nemeth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231550#comment-17231550 ] 

Szilard Nemeth commented on YARN-7200:
--------------------------------------

Hi [~akshink],

Checking your patch soon.

As a general rule of thumb, the filename of patches you attach to the jiras should look like: "YARN-<xxxxx>-<version>.patch, so for trunk you don't need to include the branch name in the filename as it's the default branch.

An example can be checked on YARN-10458.

Another important thing is to set the status of the Jira to Submit patch (should only be done once), so that Yetus can pick the change up and trigger a Jenkins build.

Later on, when you upload more patches you don't need to adjust the status of the jira, just upload the attachments with the new version number (e.g. 002) in the filename and Yetus will trigger a build again. 

This process should be automatic, however sometimes it doesn't work. In this case, committers can trigger the Jenkins build manually for any jira.

Please also note that the build can only run for the patch file that was uploaded the latest. 

> SLS generates a realtimetrack.json file but that file is missing the closing ']'
> --------------------------------------------------------------------------------
>
>                 Key: YARN-7200
>                 URL: https://issues.apache.org/jira/browse/YARN-7200
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler-load-simulator
>            Reporter: Grant Sohn
>            Assignee: Agshin Kazimli
>            Priority: Minor
>              Labels: newbie, newbie++
>         Attachments: YARN-7200-branch-trunk.patch, realtimetrack.json
>
>
> File hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SchedulerMetrics.java shows:
> {noformat}
>   void tearDown() throws Exception {
>     if (metricsLogBW != null)  {
>       metricsLogBW.write("]");
>       metricsLogBW.close();
>     }
>     ....
> {noformat}
> So the exit logic is flawed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org