You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2024/12/18 12:20:56 UTC
[PR] GH-45063: [C++] Update Bundled ABSL and GRPC [arrow]
raulcd opened a new pull request, #45064:
URL: https://github.com/apache/arrow/pull/45064
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update Bundled ABSL and GRPC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #45064:
URL: https://github.com/apache/arrow/pull/45064#discussion_r1890153185
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2990,30 +3011,40 @@ macro(build_absl)
statusor
str_format_internal
strerror
+ string_view
strings
strings_internal
symbolize
synchronization
throw_delegate
time
time_zone
- wyhash)
+ utf8_for_code_point
+ vlog_config_internal)
# Abseil creates a number of header-only targets, which are needed to resolve dependencies.
# The list can be refreshed using:
- # comm -13 <(ls -l $PREFIX/lib/libabsl_*.a | sed -e 's/.*libabsl_//' -e 's/.a$//' | sort -u) \
- # <(ls -1 $PREFIX/lib/pkgconfig/absl_*.pc | sed -e 's/.*absl_//' -e 's/.pc$//' | sort -u)
+ # comm -13 <(ls -l lib/libabsl_*.a | sed -e 's/.*libabsl_//' -e 's/.a$//' | sort -u) \
+ # <(ls -1 lib/pkgconfig/absl_*.pc | sed -e 's/.*absl_//' -e 's/.pc$//' | sort -u)
set(_ABSL_INTERFACE_LIBS
+ absl::check
+ absl::log
+ absl::vlog_is_on
Review Comment:
Those three weren't picked by the command but were necessary to build
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3948,11 +4382,13 @@ macro(build_grpc)
GRPC_C_FLAGS
" -Wno-attributes"
" -Wno-format-security"
+ " -Wno-return-type"
Review Comment:
I had to add those to avoid a bunch of those:
```
/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h: In member function 'grpc_core::Poll<typename grpc_core::promise_detail::OncePromiseFactory<void, F>::Promise::Result> grpc_core::Party::PromiseParticipantImpl<SuppliedFactory>::PollCompletion() [with SuppliedFactory = grpc_core::ForwardCall(grpc_core::CallHandler, grpc_core::CallInitiator, absl::lts_20240722::AnyInvocable<void(grpc_metadata_batch&)>)::<lambda()> mutable::<lambda(std::optional<std::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter> >)> mutable::<lambda()> mutable::<lambda(grpc_core::MessageHandle)> mutable::<lambda()>]':
/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h:284:5: warning: control reaches end of non-void function [-Wreturn-type]
284 | }
| ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update bundled Abseil and gRPC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd closed pull request #45064: GH-45063: [C++] Update bundled Abseil and gRPC
URL: https://github.com/apache/arrow/pull/45064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update Bundled ABSL and GRPC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-2551185782
I seem to be facing the same issue as:
https://github.com/grpc/grpc/issues/33887
```
-- stderr output is:
In file included from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/config_protobuf.h:22,
from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/config.h:24,
from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/csharp_generator.h:22,
from /build/cpp/grpc_ep-prefix/src/grpc_ep/src/compiler/csharp_generator.cc:19:
/build/cpp/grpc_ep-prefix/src/grpc_ep/include/grpcpp/impl/codegen/config_protobuf.h:81:10: fatal error: absl/status/status.h: No such file or directory
81 | #include "absl/status/status.h"
| ^~~~~~~~~~~~~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update Bundled ABSL and GRPC [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-2551181190
:warning: GitHub issue #45063 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update bundled Abseil and gRPC [arrow]
Posted by "JesseLovelace (via GitHub)" <gi...@apache.org>.
JesseLovelace commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-3192237521
Hi, any updates on this? Is it still blocked by https://github.com/grpc/grpc/issues/33887?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update bundled Abseil and gRPC [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-2552536626
Abseil: Let's migrate to FetchContent from ExternalProject. We don't want to maintain Abseil dependencies manually...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update Bundled ABSL and GRPC [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-2551187235
Revision: bc93d48183e14889609b7c795633840c6d72f83d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-56b96cfd95](https://github.com/ursacomputing/crossbow/branches/all?query=actions-56b96cfd95)
|Task|Status|
|----|------|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12392860590/job/34592920536)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update bundled Abseil and gRPC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-3195853884
We should restart this work with a new PR as this is quite old. I am going to close it, if someone can take some time to bump Abseil and gRPC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update bundled Abseil and gRPC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-2554703897
> Abseil: Let's migrate to FetchContent from ExternalProject. We don't want to maintain Abseil dependencies manually...
Sounds good to me, probably worth waiting to upgrade CMake then as there were a lot of additions / improvements around FetchContent around CMake 3.24.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update bundled Abseil and gRPC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-2975443615
We did upgrade to CMake minimum required version of 3.25. We probably should try and migrate Abseil build to FetchContent instead of ExternalProject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45063: [C++] Update Bundled ABSL and GRPC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45064:
URL: https://github.com/apache/arrow/pull/45064#issuecomment-2551181742
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org