You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/01 09:05:42 UTC

[GitHub] [thrift] anshulmgupta opened a new pull request #2482: THRIFT-5482: Fix memory leak during SSL handshake in C++ library

anshulmgupta opened a new pull request #2482:
URL: https://github.com/apache/thrift/pull/2482


   Client: C++
   We observed continuous memory increase in the thrift server during SSL handshake and this memory increase was crashing the windows hosts as there was no memory left for other applications to work. During further investigation, we found that ERR_remove_state has been made stub in the later versions of OpenSSL, and recommended function to clear the thread state is OPENSSL_thread_stop. Once I made this change we did not observe any memory leak further.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] emmenlau commented on pull request #2482: THRIFT-5482: Fix memory leak during SSL handshake in C++ library

Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2482:
URL: https://github.com/apache/thrift/pull/2482#issuecomment-983467759


   Builds and tests fine for me (our internal tests, not standard thrift tests) against OpenSSL 1.1.1l.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] anshulmgupta commented on pull request #2482: THRIFT-5482: Fix memory leak during SSL handshake in C++ library

Posted by GitBox <gi...@apache.org>.
anshulmgupta commented on pull request #2482:
URL: https://github.com/apache/thrift/pull/2482#issuecomment-985259670


   @emmenlau If the diff looks good to you, can you please merge the changes? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] Jens-G merged pull request #2482: THRIFT-5482: Fix memory leak during SSL handshake in C++ library

Posted by GitBox <gi...@apache.org>.
Jens-G merged pull request #2482:
URL: https://github.com/apache/thrift/pull/2482


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org