You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/03/19 22:27:29 UTC
Review Request 19422: Failing ambari-server tests due to missing version file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19422/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-5151
https://issues.apache.org/jira/browse/AMBARI-5151
Repository: ambari
Description
-------
Tests are failing, because ambari-server pom has a duplicate definition of maven-resources-plugin and as a result version file is not filtered. Just commented it out for now to provide a quick fix. That will affect only deb package generation. Also I'll create a separate jira for merging maven-resources-plugin definitions, reusing already generated version file when creating deb package and e2e testing of deb package creation.
Diffs
-----
ambari-server/pom.xml dbd5eb6
Diff: https://reviews.apache.org/r/19422/diff/
Testing
-------
Tried re-running affected patch after applying patch.
Thanks,
Dmitro Lisnichenko
Re: Review Request 19422: Failing ambari-server tests due to missing version
file
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19422/#review37803
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On March 19, 2014, 9:33 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19422/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 9:33 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-5151
> https://issues.apache.org/jira/browse/AMBARI-5151
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Tests are failing, because ambari-server pom has a duplicate definition of maven-resources-plugin and as a result version file is not filtered. Just commented it out for now to provide a quick fix. That will affect only deb package generation. Also I'll create a separate jira for merging maven-resources-plugin definitions, reusing already generated version file when creating deb package and e2e testing of deb package creation.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml dbd5eb6
>
> Diff: https://reviews.apache.org/r/19422/diff/
>
>
> Testing
> -------
>
> Tried re-running affected tests after applying patch.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 19422: Failing ambari-server tests due to missing version
file
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19422/
-----------------------------------------------------------
(Updated March 19, 2014, 9:33 p.m.)
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-5151
https://issues.apache.org/jira/browse/AMBARI-5151
Repository: ambari
Description
-------
Tests are failing, because ambari-server pom has a duplicate definition of maven-resources-plugin and as a result version file is not filtered. Just commented it out for now to provide a quick fix. That will affect only deb package generation. Also I'll create a separate jira for merging maven-resources-plugin definitions, reusing already generated version file when creating deb package and e2e testing of deb package creation.
Diffs
-----
ambari-server/pom.xml dbd5eb6
Diff: https://reviews.apache.org/r/19422/diff/
Testing (updated)
-------
Tried re-running affected tests after applying patch.
Thanks,
Dmitro Lisnichenko