You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2017/08/29 04:14:13 UTC
jclouds-labs-aws git commit: Avoid injecting on final fields
Repository: jclouds-labs-aws
Updated Branches:
refs/heads/master 381528207 -> 20854e736
Avoid injecting on final fields
This can cause thread visibility issues. Found via error-prone.
Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/commit/20854e73
Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/tree/20854e73
Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/diff/20854e73
Branch: refs/heads/master
Commit: 20854e736eb071f1801c323deec3458c157c0f5d
Parents: 3815282
Author: Andrew Gaul <ga...@apache.org>
Authored: Mon Aug 28 21:13:54 2017 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Mon Aug 28 21:13:54 2017 -0700
----------------------------------------------------------------------
.../main/java/org/jclouds/glacier/blobstore/GlacierBlobStore.java | 2 +-
.../glacier/blobstore/strategy/internal/BaseSlicingStrategy.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/blob/20854e73/glacier/src/main/java/org/jclouds/glacier/blobstore/GlacierBlobStore.java
----------------------------------------------------------------------
diff --git a/glacier/src/main/java/org/jclouds/glacier/blobstore/GlacierBlobStore.java b/glacier/src/main/java/org/jclouds/glacier/blobstore/GlacierBlobStore.java
index 4fb8c35..e7d9889 100644
--- a/glacier/src/main/java/org/jclouds/glacier/blobstore/GlacierBlobStore.java
+++ b/glacier/src/main/java/org/jclouds/glacier/blobstore/GlacierBlobStore.java
@@ -71,7 +71,7 @@ public class GlacierBlobStore extends BaseBlobStore {
@Inject(optional = true)
@Named("jclouds.glacier.inventory.update.time")
- private final long inventoryUpdateTime = DEFAULT_INVENTORY_UPDATE_TIME;
+ private long inventoryUpdateTime = DEFAULT_INVENTORY_UPDATE_TIME;
private final GlacierClient sync;
private final Provider<MultipartUploadStrategy> multipartUploadStrategy;
http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/blob/20854e73/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java
----------------------------------------------------------------------
diff --git a/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java b/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java
index 0200842..dc15230 100644
--- a/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java
+++ b/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BaseSlicingStrategy.java
@@ -40,7 +40,7 @@ public class BaseSlicingStrategy implements SlicingStrategy {
@Inject(optional = true)
@Named("jclouds.mpu.part.ratio")
- private final double ratio = DEFAULT_RATIO;
+ private double ratio = DEFAULT_RATIO;
private final PayloadSlicer slicer;
private Payload payload;