You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/23 08:38:58 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #38332: [SPARK-40750][SQL] Migrate type check failures of math expressions onto error classes

MaxGekk commented on code in PR #38332:
URL: https://github.com/apache/spark/pull/38332#discussion_r1002667108


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -143,6 +143,11 @@
           "Offset expression <offset> must be a literal."
         ]
       },
+      "INVALID_ELEMENT_TYPE" : {
+        "message" : [
+          "Input to function <functionName> cannot contain elements of <elementType>. <message>"

Review Comment:
   Let's don't pass `message`, and introduce more specific error class which includes the message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org