You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ab...@apache.org on 2012/06/07 22:34:45 UTC
svn commit: r1347777 - in
/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene: codecs/
codecs/lucene40/ codecs/simpletext/ index/
Author: ab
Date: Thu Jun 7 20:34:44 2012
New Revision: 1347777
URL: http://svn.apache.org/viewvc?rev=1347777&view=rev
Log:
LUCENE-4119 SegmentInfoFormat.getSegmentInfos{Reader,Writer} should be singular.
Modified:
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/SegmentInfoFormat.java
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40SegmentInfoFormat.java
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/simpletext/SimpleTextSegmentInfoFormat.java
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/SegmentInfoFormat.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/SegmentInfoFormat.java?rev=1347777&r1=1347776&r2=1347777&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/SegmentInfoFormat.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/SegmentInfoFormat.java Thu Jun 7 20:34:44 2012
@@ -28,6 +28,6 @@ import org.apache.lucene.index.SegmentIn
* @lucene.experimental
*/
public abstract class SegmentInfoFormat {
- public abstract SegmentInfoReader getSegmentInfosReader();
- public abstract SegmentInfoWriter getSegmentInfosWriter();
+ public abstract SegmentInfoReader getSegmentInfoReader();
+ public abstract SegmentInfoWriter getSegmentInfoWriter();
}
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40SegmentInfoFormat.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40SegmentInfoFormat.java?rev=1347777&r1=1347776&r2=1347777&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40SegmentInfoFormat.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40SegmentInfoFormat.java Thu Jun 7 20:34:44 2012
@@ -72,12 +72,12 @@ public class Lucene40SegmentInfoFormat e
private final SegmentInfoWriter writer = new Lucene40SegmentInfoWriter();
@Override
- public SegmentInfoReader getSegmentInfosReader() {
+ public SegmentInfoReader getSegmentInfoReader() {
return reader;
}
@Override
- public SegmentInfoWriter getSegmentInfosWriter() {
+ public SegmentInfoWriter getSegmentInfoWriter() {
return writer;
}
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/simpletext/SimpleTextSegmentInfoFormat.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/simpletext/SimpleTextSegmentInfoFormat.java?rev=1347777&r1=1347776&r2=1347777&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/simpletext/SimpleTextSegmentInfoFormat.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/simpletext/SimpleTextSegmentInfoFormat.java Thu Jun 7 20:34:44 2012
@@ -34,12 +34,12 @@ public class SimpleTextSegmentInfoFormat
public static final String SI_EXTENSION = "si";
@Override
- public SegmentInfoReader getSegmentInfosReader() {
+ public SegmentInfoReader getSegmentInfoReader() {
return reader;
}
@Override
- public SegmentInfoWriter getSegmentInfosWriter() {
+ public SegmentInfoWriter getSegmentInfoWriter() {
return writer;
}
}
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java?rev=1347777&r1=1347776&r2=1347777&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java Thu Jun 7 20:34:44 2012
@@ -2042,7 +2042,7 @@ public class IndexWriter implements Clos
// creating CFS so that 1) .si isn't slurped into CFS,
// and 2) .si reflects useCompoundFile=true change
// above:
- codec.segmentInfoFormat().getSegmentInfosWriter().write(directory, newSegment.info, flushedSegment.fieldInfos, context);
+ codec.segmentInfoFormat().getSegmentInfoWriter().write(directory, newSegment.info, flushedSegment.fieldInfos, context);
// TODO: ideally we would freeze newSegment here!!
// because any changes after writing the .si will be
@@ -2334,7 +2334,7 @@ public class IndexWriter implements Clos
// creating CFS so that 1) .si isn't slurped into CFS,
// and 2) .si reflects useCompoundFile=true change
// above:
- codec.segmentInfoFormat().getSegmentInfosWriter().write(trackingDir, info, mergeState.fieldInfos, context);
+ codec.segmentInfoFormat().getSegmentInfoWriter().write(trackingDir, info, mergeState.fieldInfos, context);
info.addFiles(trackingDir.getCreatedFiles());
// Register the new segment
@@ -2408,7 +2408,7 @@ public class IndexWriter implements Clos
// store segment name):
TrackingDirectoryWrapper trackingDir = new TrackingDirectoryWrapper(directory);
try {
- newInfo.getCodec().segmentInfoFormat().getSegmentInfosWriter().write(trackingDir, newInfo, fis, context);
+ newInfo.getCodec().segmentInfoFormat().getSegmentInfoWriter().write(trackingDir, newInfo, fis, context);
} catch (UnsupportedOperationException uoe) {
// OK: 3x codec cannot write a new SI file;
// SegmentInfos will write this on commit
@@ -3567,7 +3567,7 @@ public class IndexWriter implements Clos
// above:
boolean success2 = false;
try {
- codec.segmentInfoFormat().getSegmentInfosWriter().write(directory, merge.info.info, mergeState.fieldInfos, context);
+ codec.segmentInfoFormat().getSegmentInfoWriter().write(directory, merge.info.info, mergeState.fieldInfos, context);
success2 = true;
} finally {
if (!success2) {
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java?rev=1347777&r1=1347776&r2=1347777&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java Thu Jun 7 20:34:44 2012
@@ -286,7 +286,7 @@ public final class SegmentInfos implemen
String segName = input.readString();
Codec codec = Codec.forName(input.readString());
//System.out.println("SIS.read seg=" + seg + " codec=" + codec);
- SegmentInfo info = codec.segmentInfoFormat().getSegmentInfosReader().read(directory, segName, IOContext.READ);
+ SegmentInfo info = codec.segmentInfoFormat().getSegmentInfoReader().read(directory, segName, IOContext.READ);
info.setCodec(codec);
long delGen = input.readLong();
int delCount = input.readInt();