You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2012/06/06 06:08:23 UTC
[jira] [Created] (CASSANDRA-4312) fix OOM with
ReadMessageTest.testNoCommitLog
Dave Brosius created CASSANDRA-4312:
---------------------------------------
Summary: fix OOM with ReadMessageTest.testNoCommitLog
Key: CASSANDRA-4312
URL: https://issues.apache.org/jira/browse/CASSANDRA-4312
Project: Cassandra
Issue Type: Bug
Components: Tests
Affects Versions: 1.2
Reporter: Dave Brosius
Priority: Trivial
Fix For: 1.2
Attachments: fix_oom_in_readmessagetest.txt
this test can throw OOMs, because it uses a FileReader and readLine to read the commit log. However, some commit logs are fully allocated, but not initialized, (all 0s) so finding an EOL means reading 134M of data. Even for commit logs that have data they really aren't filereader-type streams.
changed to do simple byte finding in the streams instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4312) fix OOM with
ReadMessageTest.testNoCommitLog
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290739#comment-13290739 ]
Dave Brosius commented on CASSANDRA-4312:
-----------------------------------------
committed to trunk as commit de6dba73352b8406452bd2b0ab792e9af817c901
> fix OOM with ReadMessageTest.testNoCommitLog
> --------------------------------------------
>
> Key: CASSANDRA-4312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4312
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.2
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: fix_oom_in_readmessagetest.txt
>
>
> this test can throw OOMs, because it uses a FileReader and readLine to read the commit log. However, some commit logs are fully allocated, but not initialized, (all 0s) so finding an EOL means reading 134M of data. Even for commit logs that have data they really aren't filereader-type streams.
> changed to do simple byte finding in the streams instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4312) fix OOM with
ReadMessageTest.testNoCommitLog
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4312:
--------------------------------------
Reviewer: yukim
> fix OOM with ReadMessageTest.testNoCommitLog
> --------------------------------------------
>
> Key: CASSANDRA-4312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4312
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.2
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: fix_oom_in_readmessagetest.txt
>
>
> this test can throw OOMs, because it uses a FileReader and readLine to read the commit log. However, some commit logs are fully allocated, but not initialized, (all 0s) so finding an EOL means reading 134M of data. Even for commit logs that have data they really aren't filereader-type streams.
> changed to do simple byte finding in the streams instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4312) fix OOM with
ReadMessageTest.testNoCommitLog
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated CASSANDRA-4312:
------------------------------------
Attachment: fix_oom_in_readmessagetest.txt
> fix OOM with ReadMessageTest.testNoCommitLog
> --------------------------------------------
>
> Key: CASSANDRA-4312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4312
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.2
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: fix_oom_in_readmessagetest.txt
>
>
> this test can throw OOMs, because it uses a FileReader and readLine to read the commit log. However, some commit logs are fully allocated, but not initialized, (all 0s) so finding an EOL means reading 134M of data. Even for commit logs that have data they really aren't filereader-type streams.
> changed to do simple byte finding in the streams instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4312) fix OOM with
ReadMessageTest.testNoCommitLog
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290232#comment-13290232 ]
Yuki Morishita commented on CASSANDRA-4312:
-------------------------------------------
+1 with nit: you need to remove whitespaces on empty row.
> fix OOM with ReadMessageTest.testNoCommitLog
> --------------------------------------------
>
> Key: CASSANDRA-4312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4312
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.2
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: fix_oom_in_readmessagetest.txt
>
>
> this test can throw OOMs, because it uses a FileReader and readLine to read the commit log. However, some commit logs are fully allocated, but not initialized, (all 0s) so finding an EOL means reading 134M of data. Even for commit logs that have data they really aren't filereader-type streams.
> changed to do simple byte finding in the streams instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira