You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/03/21 19:07:36 UTC
Review Request 45116: GEODE-27: Adding spring-expression back in to
geode-web
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45116/
-----------------------------------------------------------
Review request for geode, Jason Huynh and Jens Deppe.
Repository: geode
Description
-------
Not tests are failing due to this, but I discovered in a manual test of
launching a locator that we were seeing errors due to the fact that the
geode-web war could not be launched due to a missing spring expression
class.
Diffs
-----
geode-web/build.gradle 11737057dc5774ba26719072458caaf8d960fed9
Diff: https://reviews.apache.org/r/45116/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 45116: GEODE-27: Adding spring-expression back in
to geode-web
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45116/#review124621
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Huynh
On March 21, 2016, 6:07 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45116/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 6:07 p.m.)
>
>
> Review request for geode, Jason Huynh and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Not tests are failing due to this, but I discovered in a manual test of
> launching a locator that we were seeing errors due to the fact that the
> geode-web war could not be launched due to a missing spring expression
> class.
>
>
> Diffs
> -----
>
> geode-web/build.gradle 11737057dc5774ba26719072458caaf8d960fed9
>
> Diff: https://reviews.apache.org/r/45116/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 45116: GEODE-27: Adding spring-expression back in
to geode-web
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45116/#review124630
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On March 21, 2016, 6:07 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45116/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 6:07 p.m.)
>
>
> Review request for geode, Jason Huynh and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Not tests are failing due to this, but I discovered in a manual test of
> launching a locator that we were seeing errors due to the fact that the
> geode-web war could not be launched due to a missing spring expression
> class.
>
>
> Diffs
> -----
>
> geode-web/build.gradle 11737057dc5774ba26719072458caaf8d960fed9
>
> Diff: https://reviews.apache.org/r/45116/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 45116: GEODE-27: Adding spring-expression back in
to geode-web
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45116/#review124640
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Bretl
On March 21, 2016, 11:07 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45116/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 11:07 a.m.)
>
>
> Review request for geode, Jason Huynh and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Not tests are failing due to this, but I discovered in a manual test of
> launching a locator that we were seeing errors due to the fact that the
> geode-web war could not be launched due to a missing spring expression
> class.
>
>
> Diffs
> -----
>
> geode-web/build.gradle 11737057dc5774ba26719072458caaf8d960fed9
>
> Diff: https://reviews.apache.org/r/45116/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>