You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/27 18:22:02 UTC

[GitHub] [helix] desaikomal opened a new pull request, #2068: Do not proceed with cluster creation if addCluster() fails.

desaikomal opened a new pull request, #2068:
URL: https://github.com/apache/helix/pull/2068

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #2066 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   In Helix-Tools - ClusterSetup::addCluster() doesn't check return value
   of HelixAdmin::addCluster() method. It proceeds even when the call
   returns failure.
   The change will throw exception to indicate creation failed.
   
   Added a unit-test to verify.
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   - testAddClusterWithFailure
   
   - The following is the result of the "mvn test" command on the appropriate module:
   START TestClusterSetup testAddClusterWithFailure at Wed Apr 27 11:09:26 PDT 2022
   END TestClusterSetup testAddClusterWithFailure at Wed Apr 27 11:09:27 PDT 2022, took: 674ms.
   ...
   [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 109.472 s - in org.apache.helix.tools.TestClusterSetup
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0
   [INFO] 
   
   (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
   
   (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] desaikomal commented on pull request #2068: Do not proceed with cluster creation if addCluster() fails.

Posted by GitBox <gi...@apache.org>.
desaikomal commented on PR #2068:
URL: https://github.com/apache/helix/pull/2068#issuecomment-1111487628

   This PR is ready to merge, approved by @xyuanlu 
   
   Commit message:
   
   Check the return status of addCluster() and throw an exception if cluster creation fails.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] junkaixue merged pull request #2068: Do not proceed with cluster creation if addCluster() fails.

Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2068:
URL: https://github.com/apache/helix/pull/2068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org