You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/08 15:23:02 UTC
[GitHub] [iotdb] Cpaulyz opened a new pull request, #6920: [IOTDB-4022] Adjust the storage_group_report_threshold according to memory for writing
Cpaulyz opened a new pull request, #6920:
URL: https://github.com/apache/iotdb/pull/6920
## Description
1. Remove storage_group_report_threshold
2. Add a new parameter write_memory_vriation_report_proportion
3. Rename `StorageGroupInfo` to `DataRegionInfo`
https://issues.apache.org/jira/browse/IOTDB-4022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on pull request #6920: [IOTDB-4022] Adjust the storage_group_report_threshold according to memory for writing
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on PR #6920:
URL: https://github.com/apache/iotdb/pull/6920#issuecomment-1214274752
Need more experiment results, maybe min(0.001*write_memory, 16M)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #6920: [IOTDB-4022] Adjust the storage_group_report_threshold according to memory for writing
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #6920:
URL: https://github.com/apache/iotdb/pull/6920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6920: [IOTDB-4022] Adjust the storage_group_report_threshold according to memory for writing
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #6920:
URL: https://github.com/apache/iotdb/pull/6920#discussion_r940966957
##########
docs/zh/UserGuide/Reference/DataNode-Config-Manual.md:
##########
@@ -826,13 +826,13 @@ IoTDB DataNode 与 Standalone 模式共用一套配置文件，均位于 IoTDB
|默认值| 0.8 |
|改后生效方式|重启服务生效|
-* storage\_group\_report\_threshold
+* write\_memory\_variation\_report\_proportion
-|名字| storage\_group\_report\_threshold |
+|名字| write\_memory\_variation\_report\_proportion |
|:---:|:---|
-|描述| 如果存储组的内存（以字节byte为单位）增加超过此阈值，则向系统报告。默认值为16MB |
-|类型| Int32 |
-|默认值| 16777216 |
+|描述| 如果存储组的内存增加超过写入可用内存的一定比例，则向系统报告。默认值为0.001 |
Review Comment:
```suggestion
|描述| 如果 DataRegion 的内存增加超过写入可用内存的一定比例，则向系统报告。默认值为0.001 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org