[GitHub] [ozone] smengcl commented on a diff in pull request #3288: HDDS-6566. [Multi-Tenant] Fix a permission check bug that prevents non-delegated admins from assigning/revoking users to/from the tenant

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #3288:
URL: https://github.com/apache/ozone/pull/3288#discussion_r849996769


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneTenantShell.java:
##########
@@ -816,6 +818,22 @@ public void testTenantSetSecret() throws IOException, InterruptedException {
       return null;
     });
 
+    // Assigning/revoking user accessIds should work for a non-delegated admin

Review Comment:
   I agree. Some of the JUnit test methods in this class has grown too large. Should probably do a test refactoring at some point (at the cost of slightly longer integration test run time due to the extra init/cleanup, but should be worth it).
   
   Moved the test to a **new** JUnit test method for assigning/revoking tenant accessIds (users) as non-delegated admin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org