You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "chinmay-bhat (via GitHub)" <gi...@apache.org> on 2024/05/19 05:36:55 UTC
[PR] Cherrypick and Publish Changes Snapshot Management Operations [iceberg-python]
chinmay-bhat opened a new pull request, #750:
URL: https://github.com/apache/iceberg-python/pull/750
PR in Progress, **not ready for review**
Create Cherry pick and Publish changes APIs and classes.
PR depends on unmerged changes in other PRs
- _deleted_data_files for _MergingSnapshotProducer from the partial deletes PR
- ancestors_of()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Cherrypick and Publish Changes Snapshot Management Operations [iceberg-python]
Posted by "chinmay-bhat (via GitHub)" <gi...@apache.org>.
chinmay-bhat commented on code in PR #750:
URL: https://github.com/apache/iceberg-python/pull/750#discussion_r1622308580
##########
tests/table/test_init.py:
##########
@@ -676,6 +676,15 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table) -> None:
)
+@pytest.mark.integration
+def test_cherrypick_snapshot(table_v2: Table):
+ cherrypick_operation = table_v2.transaction().cherrypick_snapshot(snapshot_id=3051729675574597004)
+ cherrypick_operation.cherrypick()
+ cherrypick_operation.commit()
Review Comment:
resolved. Ran test as integration test locally after pulling and merging required changes that exist in other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Cherrypick and Publish Changes Snapshot Management Operations [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #750:
URL: https://github.com/apache/iceberg-python/pull/750#issuecomment-4014960453
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Cherrypick and Publish Changes Snapshot Management Operations [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #750:
URL: https://github.com/apache/iceberg-python/pull/750#issuecomment-4061807212
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Cherrypick and Publish Changes Snapshot Management Operations [iceberg-python]
Posted by "chinmay-bhat (via GitHub)" <gi...@apache.org>.
chinmay-bhat commented on code in PR #750:
URL: https://github.com/apache/iceberg-python/pull/750#discussion_r1612036245
##########
tests/table/test_init.py:
##########
@@ -676,6 +676,15 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table) -> None:
)
+@pytest.mark.integration
+def test_cherrypick_snapshot(table_v2: Table):
+ cherrypick_operation = table_v2.transaction().cherrypick_snapshot(snapshot_id=3051729675574597004)
+ cherrypick_operation.cherrypick()
+ cherrypick_operation.commit()
Review Comment:
Not sure how to run/write this test. I get this error when I try to read the manifest files.
```../../pyiceberg/io/pyarrow.py:303: in create
output_file = self._filesystem.open_output_stream(self._path, buffer_size=self._buffer_size)
pyarrow/_fs.pyx:881: in pyarrow._fs.FileSystem.open_output_stream
???
pyarrow/error.pxi:154: in pyarrow.lib.pyarrow_internal_check_status
???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> ???
E OSError: When initiating multiple part upload for key 'test/location/metadata/snap-6884214265407574614-0-f2de21d9-9512-4f23-b567-c5664d634609.avro' in bucket 'bucket': AWS Error ACCESS_DENIED during CreateMultipartUpload operation: Access Denied
```
I'm assuming that's because we're mocking the table metadata using conftest.py, and there are no manifest files or data files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Cherrypick and Publish Changes Snapshot Management Operations [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #750: Cherrypick and Publish Changes Snapshot Management Operations
URL: https://github.com/apache/iceberg-python/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org