[GitHub] [spark] zzzzming95 commented on a diff in pull request #42609: [SPARK-44911][SQL] Create hive table with invalid column should return error class

["zzzzming95 (via GitHub)" <gi...@apache.org>]

zzzzming95 commented on code in PR #42609:
URL: https://github.com/apache/spark/pull/42609#discussion_r1304571828


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -2143,9 +2143,10 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
 
   test("Auto alias construction of get_json_object") {
     val df = Seq(("1", """{"f1": "value1", "f5": 5.23}""")).toDF("key", "jstring")
-    val expectedMsg = "Cannot create a table having a column whose name contains commas " +
-      s"in Hive metastore. Table: `$SESSION_CATALOG_NAME`.`default`.`t`; Column: " +
-      "get_json_object(jstring, $.f1)"
+    val expectedMsg = "[INVALID_HIVE_COLUMN_NAME] Cannot create the " +
+      s"table `$SESSION_CATALOG_NAME`.`default`.`t` having the " +
+      "column `get_json_object(jstring, $`.`f1)` " +
+      "whose name contains invalid characters ',' in Hive metastore."

Review Comment:
   fixed it, thanks for you review @MaxGekk 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org