[GitHub] wu-sheng commented on a change in pull request #1102: Add .NET/.NET Core components in component-libraries config

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #1102: Add .NET/.NET Core components in component-libraries config
URL: https://github.com/apache/incubator-skywalking/pull/1102#discussion_r183236098
 
 

 ##########
 File path: apm-collector/apm-collector-boot/src/main/resources/component-libraries.yml
 ##########
 @@ -122,9 +122,30 @@ Jedis:
   languages: Java
 
 
+# .NET/.NET Core components
+AspNetCore:
+  id: 1001
+  languages: C#
+EntityFrameworkCore:
+  id: 1002
+  languages: C#
+SqlClient:
+  id: 1003
+  languages: C#
+CAP:
+  id: 1004
+  languages: C#
+StackExchange.Redis:
+  id: 1005
+  languages: C#
+
+
+
 # Component Server mapping defines the server display names of some components
 # e.g.
 # Jedis is a client library in Java for Redis server
 Component-Server-Mappings:
   Jedis: Redis
+  StackExchange.Redis: Redis
+  SqlClient: SqlServer
 
 Review comment:
   Good to have these mapping.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services