[GitHub] [pulsar] nodece commented on a change in pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

[GitBox <gi...@apache.org>]

nodece commented on a change in pull request #14702:
URL: https://github.com/apache/pulsar/pull/14702#discussion_r827800429



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Brokers.java
##########
@@ -32,6 +32,41 @@
  * Admin interface for brokers management.
  */
 public interface Brokers {
+    /**
+     * Get the list of active brokers in the local cluster.
+     * <p/>
+     * Get the list of active brokers (web service addresses) in the local cluster.
+     * <p/>
+     * Response Example:
+     *
+     * <pre>
+     * <code>["prod1-broker1.messaging.use.example.com:8080", "prod1-broker2.messaging.use.example.com:8080"
+     * * * "prod1-broker3.messaging.use.example.com:8080"]</code>
+     * </pre>
+     *
+     * @return a list of (host:port)
+     * @throws NotAuthorizedException
+     *             You don't have admin permission to get the list of active brokers in the cluster
+     * @throws PulsarAdminException
+     *             Unexpected error
+     */
+    List<String> getActiveBrokers() throws PulsarAdminException;

Review comment:
       I think we can continue to use `getActiveBrokers(String cluster)`.
   
   When the `cluster` is `null`, you can request  `/`, otherwise, you can request `/{cluster}`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org