Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

["rahulgoswami (via GitHub)" <gi...@apache.org>]

rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2264499307

   Update from tests so far:
   1) Commands that work as expected: solr zk ls , solr zk upconfig
   Yet to test: zk rm, zk mv, zk mkroot, and some more of zk cp . That should cover everything talked about in the documentation (https://solr.apache.org/guide/solr/latest/deployment-guide/solr-control-script-reference.html). There are more if I dig into SolrCLI.java. Do those need to be tested as well? 
    
   2) Running the solr start -e cloud example fails. 
           Reason:  Use of --cloud instead of -cloud in RunExampleTool.java
   
   4) solr zk -help goes into infinite recursion (stack overflow). 
           Reason:  getUsage() method in ZkToolHelp.java calls itself with no base condition
   
   Exception in thread "main" java.lang.StackOverflowError
           at org.apache.solr.cli.ZkToolHelp.getUsage(ZkToolHelp.java:59)
           at org.apache.solr.cli.ZkToolHelp.getUsage(ZkToolHelp.java:59)
           at org.apache.solr.cli.ZkToolHelp.getUsage(ZkToolHelp.java:59)
           at org.apache.solr.cli.ZkToolHelp.getUsage(ZkToolHelp.java:59)
           at org.apache.solr.cli.ZkToolHelp.getUsage(ZkToolHelp.java:59)
   
   5) Executing a command incorrectly gives a message which is not clear. Eg:
          >solr zk ls
          You must invoke this subcommand using the zk command.   bin/solr zk ls.
   
   6) solr zk downconfig command fails to download given configset. Downloads an empty "conf" directory
   
   >solr zk downconfig -z localhost:9983 -n testzkcommand -d "C:\Work\Git\command-testing"
   WARN  - 2024-08-01 23:10:37.548; org.apache.solr.common.cloud.SolrZkClient; Using default ZkCredentialsInjector. ZkCredentialsInjector is not secure, it creates an empty list of credentials which leads to 'OPEN_ACL_UNSAFE' ACLs to Zookeeper nodes
   WARN  - 2024-08-01 23:10:38.842; org.apache.solr.common.cloud.SolrZkClient; Using default ZkACLProvider. DefaultZkACLProvider is not secure, it creates 'OPEN_ACL_UNSAFE' ACLs to Zookeeper nodes
   Option 'n''confname': Deprecated for removal since 9.7: Use --conf-name instead
   Downloading configset null from ZooKeeper at localhost:9983 to directory C:\Work\Git\command-testing\conf
   
   ERROR: Error downloading files from zookeeper path /configs/null to C:\Work\Git\command-testing\conf
   
   7) solr zk cp 
           Copy from Zk to local drive => works for file, but fails to copy a directory with the below error:
   
   >solr zk cp  zk:/configs/techproducts/params.json "C:\Work\Git\command-testing" -z localhost:9983  ==> This works
   Copying from 'zk:/configs/techproducts/params.json' to 'C:\Work\Git\command-testing'. ZooKeeper at localhost:9983
   WARN  - 2024-08-01 23:32:11.569; org.apache.solr.common.cloud.SolrZkClient; Using default ZkCredentialsInjector. ZkCredentialsInjector is not secure, it creates an empty list of credentials which leads to 'OPEN_ACL_UNSAFE' ACLs to Zookeeper nodes
   WARN  - 2024-08-01 23:32:11.733; org.apache.solr.common.cloud.SolrZkClient; Using default ZkACLProvider. DefaultZkACLProvider is not secure, it creates 'OPEN_ACL_UNSAFE' ACLs to Zookeeper nodes
   
   ====
   >solr zk cp -r zk:/configs/techproducts "C:\Work\Git\command-testing" -z localhost:9983    ==> This fails
   
   ERROR: Index 1 out of bounds for length 1
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org