[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1292: ORC-1299: Fix fetch data error in bench module

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #1292:
URL: https://github.com/apache/orc/pull/1292#discussion_r1005000240


##########
java/bench/fetch-data.sh:
##########
@@ -15,8 +15,18 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 mkdir -p data/sources/taxi
-(cd data/sources/taxi; wget https://s3.amazonaws.com/nyc-tlc/trip+data/yellow_tripdata_2015-11.parquet )
-(cd data/sources/taxi; wget https://s3.amazonaws.com/nyc-tlc/trip+data/yellow_tripdata_2015-12.parquet )
+(cd data/sources/taxi; wget https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2015-11.parquet )
+(cd data/sources/taxi; wget https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2015-12.parquet )
+
+if [ $? -ne 0 ]; then
+  echo "Download taxi failed."
+  exit 255
+fi

Review Comment:
   Instead of this, please add the following before line 17.
   ```bash
   set -e
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org