You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/03/17 03:40:31 UTC

[bookkeeper] branch master updated: Register jvm_memory_direct_bytes_used metric so that it's reported on Prometheus

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 1825dc0  Register jvm_memory_direct_bytes_used metric so that it's reported on Prometheus
1825dc0 is described below

commit 1825dc06c419aca33dc27efe33f5571f1e280a4b
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Fri Mar 16 20:40:23 2018 -0700

    Register jvm_memory_direct_bytes_used metric so that it's reported on Prometheus
    
    The `jvm_memory_direct_bytes_used` metric is being registered on the default Prometheus static registry, though we're only exporting the stats that were added into the local registry instance.
    
    Author: Matteo Merli <mm...@apache.org>
    
    Reviewers: Sijie Guo <si...@apache.org>
    
    This closes #1272 from merlimat/fix-mem-stats
---
 .../apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java b/bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
index a79d05d..c3dbe2d 100644
--- a/bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
+++ b/bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
@@ -125,7 +125,7 @@ public class PrometheusMetricsProvider implements StatsProvider {
             public double get() {
                 return directMemoryUsage != null ? directMemoryUsage.longValue() : Double.NaN;
             }
-        }).register(CollectorRegistry.defaultRegistry);
+        }).register(registry);
 
         Gauge.build("jvm_memory_direct_bytes_max", "-").create().setChild(new Child() {
             @Override

-- 
To stop receiving notification emails like this one, please contact
sijie@apache.org.